From: David Woodhouse <dwmw2@infradead.org>
To: Per Hedblom <per.hedblom@abem.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: eCos gc.c BUG_ON(end > JFFS2_F_I_SIZE(f))
Date: Tue, 09 Nov 2004 22:22:25 +0000 [thread overview]
Message-ID: <1100038945.21273.17.camel@baythorne.infradead.org> (raw)
In-Reply-To: <20041109205644.E9EBA37E4D@smtp3-2-sn1.fre.skanova.net>
On Tue, 2004-11-09 at 21:56 +0100, Per Hedblom wrote:
> The test that fails is BUG_ON(end > JFFS2_F_I_SIZE(f)) in the function
> jffs2_garbage_collect_dnode in gc.c.
>
> The problem is that the 288(=204+84) bytes latest written are not added to
> the inode->i_size yet but already available in the frag tree.
>
>
> I can add code to update the inode->i_size in the jffs2_write_inode_range
> after each successful write but I don't think this is correct to the jffs2
> architecture but it makes the code run.
In Linux, i_size gets updated by the core VFS code, before the call to
commit_write(), and hence before jffs2_write_inode_range() too.
Can we modify jffs2_fo_write() to do likewise?
--
dwmw2
prev parent reply other threads:[~2004-11-09 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 20:56 eCos gc.c BUG_ON(end > JFFS2_F_I_SIZE(f)) Per Hedblom
2004-11-09 22:22 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100038945.21273.17.camel@baythorne.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=per.hedblom@abem.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.