From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 1/3] net/virtio: fix mbuf data offset for simple Rx function Date: Tue, 13 Feb 2018 09:53:10 +0100 Message-ID: <1102a5a0-dc78-89ec-2a48-10253ae048ed@redhat.com> References: <20180212154612.5297-1-maxime.coquelin@redhat.com> <20180212154612.5297-2-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stable@dpdk.org, zhihong.wang@intel.com, qian.q.xu@intel.com, lei.a.yao@intel.com To: tiwei.bie@intel.com, yliu@fridaylinux.org, ferruh.yigit@intel.com, victork@redhat.com, thomas@monjalon.net, olivier.matz@6wind.com, jianfeng.tan@intel.com Return-path: In-Reply-To: <20180212154612.5297-2-maxime.coquelin@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/12/2018 04:46 PM, Maxime Coquelin wrote: > From: Olivier Matz > > The mbuf->data_off was was not properly set for the first received > mbufs. Fix this by setting it in virtqueue_enqueue_recv_refill_simple(), > which is used to enqueue the first mbuf in the ring. > > The function virtio_rxq_rearm_vec(), which is used to rearm the ring > with new mbufs, is valid and does not need to be updated. > > Fixes: cab0461234e7 ("virtio: fill Rx avail ring with blank mbufs") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_rxtx_simple.c | 1 + > 1 file changed, 1 insertion(+) > I forgot to apply my r-b when re-posting: Reviewed-by: Maxime Coquelin Maxime