Re: Re: Samsung P35 and S3 suspend

[Li Shaohua <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Mon, 2004-12-27 at 20:18, stefandoesinger-RbZlAiThDcE@public.gmane.org wrote:
> > This patch is quite interesting. If you just move '
> > acpi_leave_sleep_state(acpi_state)' to acpi_pm_leave, what's the
> result?
> > And please send me a copy of your acpidmp, I'd like look at it.
> Works too with 2.6.10. Strange, AFAIK this didn't work with 2.6.7.
> I sent the output of acpidump in a private mail(File fize)
Your original patch (move 'acpi_leave_sleep_state' and
'acpi_disable_wakeup_device' to 'acpi_pm_leave') seems safer (in case
resumed devices generate unexpected wakeup interrupts), please submit a
patch to Len.

Though I wonder if 'acpi_pm_leave' should be called before
'device_power_up' (ACPI spec said _WAK should be called before device
resume, which possibly includes system devices). There isn't a
straightforward fix for this, acpi_leave_sleep_state is designed being
called with interrupt enabled. But anyway, we can fix it till we
actually find one real bug.

Thanks,
Shaohua



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/