From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus Date: Wed, 07 Dec 2016 11:40:28 +0100 Message-ID: <11053786.o6LJ0UWG8a@xps13> References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-11-git-send-email-hemant.agrawal@nxp.com> <6b58f8fa-4df0-684e-f1d3-4dc4dba4f0dd@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Hemant Agrawal , dev@dpdk.org, bruce.richardson@intel.com, david.marchand@6wind.com To: Shreyansh Jain Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 14E762B96 for ; Wed, 7 Dec 2016 11:40:30 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id c184so33661286wmd.0 for ; Wed, 07 Dec 2016 02:40:30 -0800 (PST) In-Reply-To: <6b58f8fa-4df0-684e-f1d3-4dc4dba4f0dd@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-07 15:43, Shreyansh Jain: > IMO, the way Bus is kept is debatable. > - should it be in EAL (lib/librte_eal/linuxapp/eal_pci.c like Bus > patches) [1]? > - Should it a 'handler/driver' parallel to device drivers? > > I personally prefer a clean layer for buses with: > > - RTE_SDK/drivers/net/dpaa2/ > - RTE_SDK/drivers/bus > - RTE_SDK/drivers/bus/dpaa2/ > - RTE_SDK/drivers/bus/dpaa2/dpaa2_bus.c etc. I agree, it is a good idea. > For PCI, which is generic (or for other similar generic buses, like > platform), we can keep the implementation within lib/librte_eal/linuxapp/*. I would be in favor of moving PCI and vdev code from EAL to drivers/bus/. We can keep the API in EAL and implement the buses as drivers. Other opinions?