Re: [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

From: Anoob Joseph <anoob.joseph@caviumnetworks.com>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	dev@dpdk.org
Subject: Re: [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions
Date: Fri, 8 Dec 2017 22:10:28 +0530	[thread overview]
Message-ID: <11087367-b892-aae7-07bc-555232a0ce8d@caviumnetworks.com> (raw)
In-Reply-To: <20171208144000.seega54cbv7prktb@laranjeiro-vm.dev.6wind.com>

HI Nelio,

On 08-12-2017 20:10, Nelio Laranjeiro wrote:
> On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote:
>> Hi Nelio,
>>
>>
> [...]
>>> +					goto flow_create;
>>> +				/* Try Queue. */
>>> +				for (i = 0;
>>> +				     i < eth_dev->data->nb_rx_queues; ++i)
>>> +					if (eth_dev->data->rx_queues[i])
>>> +						break;
>> Is the following check correct?
> [...]
>
> For an application, it seems not necessary.  The application knows which
> queues are configured in the drivers has it has made the configuration.
>
> Removing it in the v3.
I think you misunderstood me here.

I was talking about the following line.

+				if (i != eth_dev->data->nb_rx_queues)
+					return -1;

Shouldn't it be?

+				if (i == eth_dev->data->nb_rx_queues)
+					return -1;

Thanks,
Anoob