From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] vhost: fix mmap failure as len not
	aligned with hugepage size
Date: Tue, 24 Nov 2015 19:24:40 +0100
Message-ID: <111424458.gvWv4ThTcC@xps13>
References: <1447279449-11289-1-git-send-email-jianfeng.tan@intel.com>
 <1447308361-82139-1-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 69516568A
 for <dev@dpdk.org>; Tue, 24 Nov 2015 19:25:58 +0100 (CET)
Received: by wmec201 with SMTP id c201so222505720wme.0
 for <dev@dpdk.org>; Tue, 24 Nov 2015 10:25:58 -0800 (PST)
In-Reply-To: <1447308361-82139-1-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-12 14:06, Jianfeng Tan:
> This patch fixes a bug under lower version linux kernel, mmap()
> fails when length is not aligned with hugepage size. mmap()
> without flag of MAP_ANONYMOUS, should be called with length
> argument aligned with hugepagesz at older longterm version
> Linux, like 2.6.32 and 3.2.72, or mmap() will fail with EINVAL.
> This bug was fixed in Linux kernel by commit:
> dab2d3dc45ae7343216635d981d43637e1cb7d45
> To avoid failure, make sure in caller to keep length aligned.
> 
> v3 changes:
>  - fix (u64) -> (void *) convert error on 32-bit system
> 
> v2 changes:
>  - add Kernel version comments and commit msg
>  - remove unnecessary alignments when munmap
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

You forgot to keep Huawei's ack from v2.

Applied, thanks