From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Baldwin Subject: Re: [PATCH RFC 07/13] xen: implement IO APIC support in Xen mptable parser Date: Sat, 08 Feb 2014 16:36:11 -0500 Message-ID: <11166680.j6yj7PCWSG__45766.868760302$1392323212$gmane$org@ralph.baldwin.cx> References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com> <1387884062-41154-8-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WE2qD-0006bB-5m for xen-devel@lists.xenproject.org; Thu, 13 Feb 2014 20:25:01 +0000 In-Reply-To: <1387884062-41154-8-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org, gibbs@freebsd.org List-Id: xen-devel@lists.xenproject.org On Tuesday, December 24, 2013 12:20:56 PM Roger Pau Monne wrote: > Use madt_setup_io (from madt.c) on Xen apic_enumerator, in order to > parse the interrupt sources from the IO APIC. > > I would like to get opinions, but I think we should rename and move > madt_setup_io to io_apic.c. It wouldn't be appropriate for io_apic.c as it isn't generic to I/O APICs but is specific to ACPI. However, mptable.c is really not a great name for this file in sys/x86/xen. I wonder if it should be xen_apic.c instead? Also, if Xen PV has an MADT table, why do you need a custom APIC enumerator at all? That is, what is preventing the code in madt.c from just working? Do you just not have 'device acpi' in the kernel config you are using? -- John Baldwin