Re: [PATCH 2.6.12-rc5 4/10] mm: manual page migration-rc3 -- add-sys_migrate_pages-rc3.patch

From: Dave Hansen <haveblue@us.ibm.com>
To: Ray Bryant <raybry@engr.sgi.com>
Cc: Ray Bryant <raybry@sgi.com>,
	Hirokazu Takahashi <taka@valinux.co.jp>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Andi Kleen <ak@suse.de>, Christoph Hellwig <hch@infradead.org>,
	Ray Bryant <raybry@austin.rr.com>, linux-mm <linux-mm@kvack.org>,
	lhms <lhms-devel@lists.sourceforge.net>,
	Paul Jackson <pj@sgi.com>, Nathan Scott <nathans@sgi.com>
Subject: Re: [PATCH 2.6.12-rc5 4/10] mm: manual page migration-rc3 --	add-sys_migrate_pages-rc3.patch
Date: Wed, 22 Jun 2005 18:42:02 -0700	[thread overview]
Message-ID: <1119490922.18457.73.camel@localhost> (raw)
In-Reply-To: <42BA11AF.4080302@engr.sgi.com>

On Wed, 2005-06-22 at 20:34 -0500, Ray Bryant wrote:
> Dave Hansen wrote:
> > On Wed, 2005-06-22 at 09:39 -0700, Ray Bryant wrote:
> > 
> >>+asmlinkage long
> >>+sys_migrate_pages(pid_t pid, __u32 count, __u32 *old_nodes, __u32 *new_nodes)
> >>+{
> >  
> > Should the buffers be marked __user?
> > 
> 
> I've tried it both ways, but with the __user in the system call declaration,
> you still need to have it on the copy_from_user() calls to get sparse to
> shut up, so it really doesn't appear to help much to put it in the 
> declaration.  I'm easy though.  If you think it helps, I'll add it.

Looking at fs/read_write.c, the convention seems to be to put them in
the function declaration.  That's all that I was looking at.  No big
deal.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>