From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28081C433EF for ; Fri, 22 Apr 2022 12:03:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C7FD83CA4; Fri, 22 Apr 2022 14:03:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="B7e8rlmx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8138783CF3; Fri, 22 Apr 2022 14:03:33 +0200 (CEST) Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ADC7683C70 for ; Fri, 22 Apr 2022 14:03:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pg1-x535.google.com with SMTP id t4so7185693pgc.1 for ; Fri, 22 Apr 2022 05:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bj8V3BuhfC6Kq6l4k6oRIAEtwbFSCpEniNbhb4uLgWM=; b=B7e8rlmxgnIy10ZUPx1+3PE0/XcDN9v5Z5jFgiTmqIn5ZZ5fBs8RFmke/zCQfRJNIM uMhfHrXSkpfXIbCbaBLR1T73IqyO5boZreXpTZMXqEBFN3aF19LFCs28+PdjmjfWFHFn lo76nrKty7gDwAQXI7FKL9fJxy4mgKPGKgUU0QVVmLxcbEd4MkKg4pT56d1YVDP9nxBB FpS0udxt/zkI2m4p2lWddAqsi9kDp1SnZ1zBCu2MdiWx1nwjcEd2Q2pKDYkFQFZ+Kqhe qU6Q9aONqsXEmhvkVt/pFFXIcu8Ion78eze9F5r7Ry0gyB00+t9cr4terf2hdQzyHKT/ qcSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bj8V3BuhfC6Kq6l4k6oRIAEtwbFSCpEniNbhb4uLgWM=; b=sZgGgrrSn83zycU2dl4ulrFaAl/+fvgzGSCck5bFihYrjMgQETliikFyZFkP1ZkiUG oDb3opjp5rdEwMP8VZHUNvF10M5QWPuu5KHAKd1XEsyhVMeR0kuKl2FUtUBiRwpGY/Qr v0cO1xFeTo0jZwTnUvMJ0q0QDxMlSaWR1+EVtCR8AVm1xb1A0jACukeJTwaNwTRI9SdI R6AfW14W3oEd5TVsFpvEbxNsJpdkr7E0GjLPqoxkGLVMi8/jHu+asJrnfEUsp8qg8vFD jbnPT7IxVN2QJ17lPxqu3fhm+cX7x8mSE2fhwORTZfL5+IVG0/KO2oXIFtFZzbtpt8ld 5G0A== X-Gm-Message-State: AOAM532cXoPPm5xP+rDhT89vxxNPfDIRvGPYhBIOIB01ZzaWDa0nrX4+ 7Hm7tH8XAnRiyusM78h9aao= X-Google-Smtp-Source: ABdhPJzrImzWnLd2WhHiBZnjVIeMaFwAYpyBh3SAjy53Yy3+akXapGRGQTnueK+znoOBwe9aP/sshg== X-Received: by 2002:a63:350e:0:b0:3a9:fb92:85b8 with SMTP id c14-20020a63350e000000b003a9fb9285b8mr3582056pga.328.1650629008900; Fri, 22 Apr 2022 05:03:28 -0700 (PDT) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id 5-20020a631045000000b0039d942d18f0sm2061614pgq.48.2022.04.22.05.03.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 05:03:27 -0700 (PDT) Message-ID: <111b062b-e674-abf1-0f1d-8c8362c28772@gmail.com> Date: Fri, 22 Apr 2022 21:03:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/4] mmc: sandbox: Initialize backing buffer Content-Language: en-US To: Sean Anderson , u-boot@lists.denx.de Cc: Peng Fan , Simon Glass , Jaehoon Chung References: <20220330165446.438925-1-seanga2@gmail.com> <20220330165446.438925-3-seanga2@gmail.com> From: Jaehoon Chung In-Reply-To: <20220330165446.438925-3-seanga2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/31/22 01:54, Sean Anderson wrote: > Private data is initialized to all zeros by DM. Malloc does not do this. > Initialize it. This fixes partition detection logic from trying to detect > partitions in uninitialized memory. > > Fixes: 0bf61aced2 ("sandbox: mmc: Support a backing file") > Signed-off-by: Sean Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/mmc/sandbox_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/sandbox_mmc.c b/drivers/mmc/sandbox_mmc.c > index 35159451e1..60a6be0add 100644 > --- a/drivers/mmc/sandbox_mmc.c > +++ b/drivers/mmc/sandbox_mmc.c > @@ -178,7 +178,7 @@ static int sandbox_mmc_probe(struct udevice *dev) > priv->csize = 0; > priv->size = (priv->csize + 1) * SIZE_MULTIPLE; /* 1 MiB */ > > - priv->buf = malloc(priv->size); > + priv->buf = calloc(1, priv->size); > if (!priv->buf) { > log_err("%s: Not enough memory (%x bytes)\n", > dev->name, priv->size);