From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 4/9] target: don't depend on SCSI To: Kees Cook , Jens Axboe Cc: Christoph Hellwig , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Sagar Dharia , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Bart Van Assche References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-5-keescook@chromium.org> From: Randy Dunlap Message-ID: <111cb1b0-24ba-bcb2-53d5-9665d2b4c421@infradead.org> Date: Mon, 6 Aug 2018 16:38:52 -0700 MIME-Version: 1.0 In-Reply-To: <20180731195155.46664-5-keescook@chromium.org> Content-Type: text/plain; charset=utf-8 Sender: linux-ide-owner@vger.kernel.org List-ID: On 07/31/2018 12:51 PM, Kees Cook wrote: > From: Christoph Hellwig > > The core target code only needs code from scsi_common.c, which is now > separately selectable. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Kees Cook > --- > drivers/target/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/Kconfig b/drivers/target/Kconfig > index 4c44d7bed01a..cb6f32ce7de8 100644 > --- a/drivers/target/Kconfig > +++ b/drivers/target/Kconfig > @@ -1,10 +1,10 @@ > > menuconfig TARGET_CORE > tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure" > - depends on SCSI && BLOCK > + depends on BLOCK > select CONFIGFS_FS > select CRC_T10DIF > - select BLK_SCSI_REQUEST # only for scsi_command_size_tbl.. > + select BLK_SCSI_REQUEST > select SGL_ALLOC > default n > help > @@ -29,6 +29,7 @@ config TCM_FILEIO > > config TCM_PSCSI > tristate "TCM/pSCSI Subsystem Plugin for Linux/SCSI" > + depends on SCSI > help > Say Y here to enable the TCM/pSCSI subsystem plugin for non-buffered > passthrough access to Linux/SCSI device > Hi, This patch causes build errors in linux-next-20180806 when SCSI=m and LOOPBACK_TARGET=y. drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_link': tcm_loop.c:(.text+0x445): undefined reference to `scsi_add_device' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_remove': tcm_loop.c:(.text+0x55c): undefined reference to `scsi_remove_host' tcm_loop.c:(.text+0x564): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_submission_work': tcm_loop.c:(.text+0x7c4): undefined reference to `scmd_printk' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_probe': tcm_loop.c:(.text+0x7fb): undefined reference to `scsi_host_alloc' tcm_loop.c:(.text+0x85b): undefined reference to `scsi_add_host_with_dma' tcm_loop.c:(.text+0x896): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_unlink': tcm_loop.c:(.text+0x962): undefined reference to `scsi_device_lookup' tcm_loop.c:(.text+0x972): undefined reference to `scsi_remove_device' tcm_loop.c:(.text+0x97a): undefined reference to `scsi_device_put' drivers/target/loopback/tcm_loop.o:(.data+0x210): undefined reference to `scsi_change_queue_depth' -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH v2 4/9] target: don't depend on SCSI Date: Mon, 6 Aug 2018 16:38:52 -0700 Message-ID: <111cb1b0-24ba-bcb2-53d5-9665d2b4c421@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-5-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180731195155.46664-5-keescook@chromium.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook , Jens Axboe Cc: Christoph Hellwig , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= List-Id: linux-ide@vger.kernel.org On 07/31/2018 12:51 PM, Kees Cook wrote: > From: Christoph Hellwig > > The core target code only needs code from scsi_common.c, which is now > separately selectable. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Kees Cook > --- > drivers/target/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/Kconfig b/drivers/target/Kconfig > index 4c44d7bed01a..cb6f32ce7de8 100644 > --- a/drivers/target/Kconfig > +++ b/drivers/target/Kconfig > @@ -1,10 +1,10 @@ > > menuconfig TARGET_CORE > tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure" > - depends on SCSI && BLOCK > + depends on BLOCK > select CONFIGFS_FS > select CRC_T10DIF > - select BLK_SCSI_REQUEST # only for scsi_command_size_tbl.. > + select BLK_SCSI_REQUEST > select SGL_ALLOC > default n > help > @@ -29,6 +29,7 @@ config TCM_FILEIO > > config TCM_PSCSI > tristate "TCM/pSCSI Subsystem Plugin for Linux/SCSI" > + depends on SCSI > help > Say Y here to enable the TCM/pSCSI subsystem plugin for non-buffered > passthrough access to Linux/SCSI device > Hi, This patch causes build errors in linux-next-20180806 when SCSI=m and LOOPBACK_TARGET=y. drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_link': tcm_loop.c:(.text+0x445): undefined reference to `scsi_add_device' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_remove': tcm_loop.c:(.text+0x55c): undefined reference to `scsi_remove_host' tcm_loop.c:(.text+0x564): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_submission_work': tcm_loop.c:(.text+0x7c4): undefined reference to `scmd_printk' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_probe': tcm_loop.c:(.text+0x7fb): undefined reference to `scsi_host_alloc' tcm_loop.c:(.text+0x85b): undefined reference to `scsi_add_host_with_dma' tcm_loop.c:(.text+0x896): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_unlink': tcm_loop.c:(.text+0x962): undefined reference to `scsi_device_lookup' tcm_loop.c:(.text+0x972): undefined reference to `scsi_remove_device' tcm_loop.c:(.text+0x97a): undefined reference to `scsi_device_put' drivers/target/loopback/tcm_loop.o:(.data+0x210): undefined reference to `scsi_change_queue_depth' -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Mon, 06 Aug 2018 23:38:52 +0000 Subject: Re: [PATCH v2 4/9] target: don't depend on SCSI Message-Id: <111cb1b0-24ba-bcb2-53d5-9665d2b4c421@infradead.org> List-Id: References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-5-keescook@chromium.org> In-Reply-To: <20180731195155.46664-5-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kees Cook , Jens Axboe Cc: Christoph Hellwig , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Sagar Dharia , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Bart Van Assche On 07/31/2018 12:51 PM, Kees Cook wrote: > From: Christoph Hellwig > > The core target code only needs code from scsi_common.c, which is now > separately selectable. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Kees Cook > --- > drivers/target/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/Kconfig b/drivers/target/Kconfig > index 4c44d7bed01a..cb6f32ce7de8 100644 > --- a/drivers/target/Kconfig > +++ b/drivers/target/Kconfig > @@ -1,10 +1,10 @@ > > menuconfig TARGET_CORE > tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure" > - depends on SCSI && BLOCK > + depends on BLOCK > select CONFIGFS_FS > select CRC_T10DIF > - select BLK_SCSI_REQUEST # only for scsi_command_size_tbl.. > + select BLK_SCSI_REQUEST > select SGL_ALLOC > default n > help > @@ -29,6 +29,7 @@ config TCM_FILEIO > > config TCM_PSCSI > tristate "TCM/pSCSI Subsystem Plugin for Linux/SCSI" > + depends on SCSI > help > Say Y here to enable the TCM/pSCSI subsystem plugin for non-buffered > passthrough access to Linux/SCSI device > Hi, This patch causes build errors in linux-next-20180806 when SCSI=m and LOOPBACK_TARGET=y. drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_link': tcm_loop.c:(.text+0x445): undefined reference to `scsi_add_device' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_remove': tcm_loop.c:(.text+0x55c): undefined reference to `scsi_remove_host' tcm_loop.c:(.text+0x564): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_submission_work': tcm_loop.c:(.text+0x7c4): undefined reference to `scmd_printk' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_driver_probe': tcm_loop.c:(.text+0x7fb): undefined reference to `scsi_host_alloc' tcm_loop.c:(.text+0x85b): undefined reference to `scsi_add_host_with_dma' tcm_loop.c:(.text+0x896): undefined reference to `scsi_host_put' drivers/target/loopback/tcm_loop.o: In function `tcm_loop_port_unlink': tcm_loop.c:(.text+0x962): undefined reference to `scsi_device_lookup' tcm_loop.c:(.text+0x972): undefined reference to `scsi_remove_device' tcm_loop.c:(.text+0x97a): undefined reference to `scsi_device_put' drivers/target/loopback/tcm_loop.o:(.data+0x210): undefined reference to `scsi_change_queue_depth' -- ~Randy