All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Martin Kaiser <martin@kaiser.cx>,
	"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] staging: r8188eu: remove some functions from hal_ops
Date: Sat, 4 Sep 2021 21:06:30 +0200	[thread overview]
Message-ID: <11231264-b315-9994-31c4-b1f2e463ebd7@gmail.com> (raw)
In-Reply-To: <CAA=Fs0ntWh8kanSBMA+jBLHAgVTAjH7SFJ8ROrmncZTkzSy-gQ@mail.gmail.com>

On 9/4/21 20:27, Phillip Potter wrote:
> On Sat, 4 Sept 2021 at 13:40, Michael Straube <straube.linux@gmail.com> wrote:
>>
>> Getting rid of the hal layer is on the todo list. This series
>> removes some functions from hal_ops and make the driver call the
>> pointed functions directly.
>>
>> Tested with Inter-Tech DMG-02.
>>
>> Michael Straube (6):
>>    staging: r8188eu: remove intf_chip_configure from hal_ops
>>    staging: r8188eu: remove read_adapter_info from hal_ops
>>    staging: r8188eu: remove read_chip_version from hal_ops
>>    staging: r8188eu: remove wrapper around ReadChipVersion8188E()
>>    staging: r8188eu: remove GetHalODMVarHandler from hal_ops
>>    staging: r8188eu: remove init_default_value from hal_ops
>>
>>   drivers/staging/r8188eu/hal/hal_intf.c        | 33 -------------------
>>   .../staging/r8188eu/hal/rtl8188e_hal_init.c   | 16 +--------
>>   drivers/staging/r8188eu/hal/usb_halinit.c     | 10 ++----
>>   drivers/staging/r8188eu/include/hal_intf.h    | 22 +++----------
>>   .../staging/r8188eu/include/rtl8188e_hal.h    |  2 ++
>>   drivers/staging/r8188eu/os_dep/os_intfs.c     |  4 +--
>>   drivers/staging/r8188eu/os_dep/usb_intf.c     |  7 ++--
>>   7 files changed, 16 insertions(+), 78 deletions(-)
>>
>> --
>> 2.33.0
>>
> 
> Dear Michael,
> 
> Looks good to me, built and tested here:
> Acked-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Regards,
> Phil
> 

Thanks for your review and testing Phillip.
Much appreciated.

Regards,
Michael

      reply	other threads:[~2021-09-04 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-04 12:40 [PATCH 0/6] staging: r8188eu: remove some functions from hal_ops Michael Straube
2021-09-04 12:40 ` [PATCH 1/6] staging: r8188eu: remove intf_chip_configure " Michael Straube
2021-09-04 12:40 ` [PATCH 2/6] staging: r8188eu: remove read_adapter_info " Michael Straube
2021-09-04 12:40 ` [PATCH 3/6] staging: r8188eu: remove read_chip_version " Michael Straube
2021-09-04 12:40 ` [PATCH 4/6] staging: r8188eu: remove wrapper around ReadChipVersion8188E() Michael Straube
2021-09-04 12:40 ` [PATCH 5/6] staging: r8188eu: remove GetHalODMVarHandler from hal_ops Michael Straube
2021-09-04 12:40 ` [PATCH 6/6] staging: r8188eu: remove init_default_value " Michael Straube
2021-09-04 18:27 ` [PATCH 0/6] staging: r8188eu: remove some functions " Phillip Potter
2021-09-04 18:27   ` Phillip Potter
2021-09-04 19:06   ` Michael Straube [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11231264-b315-9994-31c4-b1f2e463ebd7@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.