From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>, Donghyeok Kim <dthex5d@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Ohhoon Kwon <ohkwon1043@gmail.com>,
JaeSang Yoo <jsyoo5b@gmail.com>,
Wonhyuk Yang <vvghjk1234@gmail.com>,
Jiyoup Kim <lakroforce@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/mmzone: Introduce a new macro for_each_node_zonelist()
Date: Tue, 19 Apr 2022 14:53:16 +0200 [thread overview]
Message-ID: <1126a1ae-8eff-8962-4253-d6e430ecc892@redhat.com> (raw)
In-Reply-To: <Yl1wO/cqNJYf0H7Y@kernel.org>
On 18.04.22 16:05, Mike Rapoport wrote:
> On Sat, Apr 16, 2022 at 10:20:35PM +0900, Donghyeok Kim wrote:
>> There are some codes using for_each_zone_zonelist() even when only
>> iterating each node is needed. This commit introduces a new macro
>> for_each_node_zonelist() which iterates through valid nodes in the
>> zonelist.
>>
>> By using this new macro, code can be written in a much simpler form.
>> Also, slab/slub can now skip trying to allocate from the node which was
>> previously tried and failed.
>>
>> Co-developed-by: Ohhoon Kwon <ohkwon1043@gmail.com>
>> Signed-off-by: Ohhoon Kwon <ohkwon1043@gmail.com>
>> Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
>> ---
>> V1 -> V2: Fix a compile error
>>
>> include/linux/mmzone.h | 36 ++++++++++++++++++++++++++++++++++++
>> mm/hugetlb.c | 17 +++++++----------
>> mm/mmzone.c | 17 +++++++++++++++++
>> mm/slab.c | 7 ++-----
>> mm/slub.c | 8 ++++----
>> mm/vmscan.c | 16 ++++++----------
>> 6 files changed, 72 insertions(+), 29 deletions(-)
>
> Even counting the comments this does not look like a great simplification.
>
I tend to agree.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-04-19 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 13:20 [PATCH v2] mm/mmzone: Introduce a new macro for_each_node_zonelist() Donghyeok Kim
2022-04-18 14:05 ` Mike Rapoport
2022-04-19 12:53 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126a1ae-8eff-8962-4253-d6e430ecc892@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dthex5d@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jsyoo5b@gmail.com \
--cc=lakroforce@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=ohkwon1043@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=vvghjk1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.