From: Chanwoo Choi <cwchoi00@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
rafael@kernel.org, andriy.shevchenko@linux.intel.com
Cc: linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"open list:DEVICE FREQUENCY (DEVFREQ)" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] devfreq: Use HZ macros
Date: Fri, 26 Feb 2021 18:14:18 +0900 [thread overview]
Message-ID: <112760b7-0594-2077-b632-ea5611481be6@gmail.com> (raw)
In-Reply-To: <09954745-5b39-8718-ca79-3e92a85e5ace@linaro.org>
On 21. 2. 26. 오후 5:51, Daniel Lezcano wrote:
> On 26/02/2021 07:08, Chanwoo Choi wrote:
>>
>>
>> On 21. 2. 24. 오후 11:42, Daniel Lezcano wrote:
>>> HZ unit conversion macros are available in units.h, use them and
>>> remove the duplicate definition.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Reviewed-by: Christian Eggers <ceggers@arri.de>
>>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>> drivers/devfreq/devfreq.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>>> index bf3047896e41..b6d63f02d293 100644
>>> --- a/drivers/devfreq/devfreq.c
>>> +++ b/drivers/devfreq/devfreq.c
>>> @@ -26,6 +26,7 @@
>>> #include <linux/hrtimer.h>
>>> #include <linux/of.h>
>>> #include <linux/pm_qos.h>
>>> +#include <linux/units.h>
>>> #include "governor.h"
>>> #define CREATE_TRACE_POINTS
>>> @@ -33,7 +34,6 @@
>>> #define IS_SUPPORTED_FLAG(f, name) ((f & DEVFREQ_GOV_FLAG_##name)
>>> ? true : false)
>>> #define IS_SUPPORTED_ATTR(f, name) ((f & DEVFREQ_GOV_ATTR_##name) ?
>>> true : false)
>>> -#define HZ_PER_KHZ 1000
>>> static struct class *devfreq_class;
>>> static struct dentry *devfreq_debugfs;
>>>
>>
>> I changed the patch title with 'PM /' prefix as following
>> in order to keep the consistent patch style if there are no any special
>> objection.
>> - PM / devfreq: Use HZ macros
>>
>> Applied it.
>
> It should not compile. This patch and others depend on 1/9.
>
> It would make sense to merge all of them through linux-pm.
OK. I'm OK to apply it to linux-pm.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2021-02-26 9:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 14:42 [PATCH v2 1/9] units: Add the HZ macros Daniel Lezcano
2021-02-24 14:42 ` [PATCH v2 2/9] thermal/drivers/devfreq_cooling: Use " Daniel Lezcano
2021-02-24 14:42 ` [PATCH v2 3/9] devfreq: " Daniel Lezcano
2021-02-26 6:08 ` Chanwoo Choi
2021-02-26 8:51 ` Daniel Lezcano
2021-02-26 9:14 ` Chanwoo Choi [this message]
2021-02-24 14:42 ` [PATCH v2 4/9] iio/drivers/as73211: " Daniel Lezcano
2021-03-14 16:59 ` Jonathan Cameron
2021-02-24 14:42 ` [PATCH v2 5/9] hwmon/drivers/mr75203: " Daniel Lezcano
2021-03-11 21:44 ` Guenter Roeck
2021-02-24 14:42 ` [PATCH v2 6/9] iio/drivers/hid-sensor: " Daniel Lezcano
2021-03-14 17:00 ` Jonathan Cameron
2021-02-24 14:42 ` [PATCH v2 7/9] i2c/drivers/ov02q10: " Daniel Lezcano
2021-02-24 14:42 ` [PATCH v2 8/9] mtd/drivers/nand: " Daniel Lezcano
2021-02-24 14:42 ` Daniel Lezcano
2021-03-02 16:31 ` Miquel Raynal
2021-03-02 16:31 ` Miquel Raynal
2021-03-02 17:03 ` Daniel Lezcano
2021-03-02 17:03 ` Daniel Lezcano
2021-03-02 17:12 ` Miquel Raynal
2021-03-02 17:12 ` Miquel Raynal
2021-02-24 14:42 ` [PATCH v2 9/9] phy/drivers/stm32: " Daniel Lezcano
2021-02-24 14:42 ` Daniel Lezcano
2021-03-02 16:32 ` Vinod Koul
2021-03-02 16:32 ` Vinod Koul
2021-03-02 17:03 ` Daniel Lezcano
2021-03-02 17:03 ` Daniel Lezcano
2021-03-03 5:40 ` Vinod Koul
2021-03-03 5:40 ` Vinod Koul
2021-03-03 6:09 ` Daniel Lezcano
2021-03-03 6:09 ` Daniel Lezcano
2021-02-24 14:52 ` [PATCH v2 1/9] units: Add the " Daniel Lezcano
2021-02-25 11:22 ` Andy Shevchenko
2021-03-19 8:08 ` Daniel Lezcano
2021-05-10 12:59 ` Andy Shevchenko
2021-07-12 16:34 ` Andy Shevchenko
2021-07-15 14:03 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=112760b7-0594-2077-b632-ea5611481be6@gmail.com \
--to=cwchoi00@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.