From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: [autofs] [RFC PATCH]autofs4: hang and proposed fix Date: Fri, 02 Dec 2005 13:12:27 -0500 Message-ID: <1133547148.8976.25.camel@lade.trondhjem.org> References: <20051116101740.GA9551@RAM> <17292.64892.680738.833917@segfault.boston.redhat.com> <1133315771.8978.65.camel@lade.trondhjem.org> <438E0C66.6040607@us.ibm.com> <1133384015.8974.35.camel@lade.trondhjem.org> <438E1A05.7000308@us.ibm.com> <438F251B.7060602@us.ibm.com> <43906968.6080508@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Will Taber , Jeff Moyer , Ram Pai , autofs mailing list , linux-fsdevel Return-path: Received: from pat.uio.no ([129.240.130.16]:9153 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S1750848AbVLBSMy (ORCPT ); Fri, 2 Dec 2005 13:12:54 -0500 To: Ian Kent In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, 2005-12-03 at 01:29 +0800, Ian Kent wrote: > It's sufficient to recognize the nameidata struct is NULL on a call > from lookup_hash nothing more that I'm aware of is needed. If that changes > then of course autofs will need to be changed. autofs also makes > assumptions about what flags are set for different reasons. Consider those cases where the VFS calls ->lookup()/->d_revalidate() with the nameidata argument set to NULL to be bugs. They are pretty much all slated to be fixed soon in order to enable features like read-only bind mounts etc. Cheers, Trond