From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v1 net-next 02/14] net: Add a new socket option for a future transmit time. Date: Wed, 27 Jun 2018 17:05:50 -0700 Message-ID: <113cec18-2b12-f163-47fb-cd5a39b992a4@gmail.com> References: <20180627215950.6719-1-jesus.sanchez-palencia@intel.com> <20180627215950.6719-3-jesus.sanchez-palencia@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: tglx@linutronix.de, jan.altenberg@linutronix.de, vinicius.gomes@intel.com, kurt.kanzenbach@linutronix.de, henrik@austad.us, richardcochran@gmail.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, mlichvar@redhat.com, willemb@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Jesus Sanchez-Palencia , Eric Dumazet , netdev@vger.kernel.org Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:45924 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbeF1AFx (ORCPT ); Wed, 27 Jun 2018 20:05:53 -0400 Received: by mail-pl0-f66.google.com with SMTP id bi1-v6so1804418plb.12 for ; Wed, 27 Jun 2018 17:05:53 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/27/2018 04:07 PM, Jesus Sanchez-Palencia wrote: > I'm failing to see how... There is a memset() in sock.c:1147 clearing all the 8 > bytes that we later use to (explicitly) assign each member of the struct. Aren't > the 2 extra bytes sanitized, then? What have I missed? Nothing, it seems I missed the memset(), it was not seen in the context of your patch and I have not checked the whole function.