From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Mon, 23 Oct 2017 15:35:18 +0200 Subject: [U-Boot] [PATCH 3/3] efi_loader: Do not enable it by default for sunxi In-Reply-To: References: <20171019082649.27819-1-maxime.ripard@free-electrons.com> <20171019082649.27819-4-maxime.ripard@free-electrons.com> Message-ID: <1142b850-31a9-e043-d5d5-c96a3562f7f8@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/19/2017 10:43 AM, Peter Robinson wrote: > On Thu, Oct 19, 2017 at 9:26 AM, Maxime Ripard > wrote: >> The EFI loader support takes around 31kB on an ARMv7 board, which makes us >> trip across the size limit we've had on the U-Boot binary. >> >> Since it's not an essential feature, disable it by default for ARCH_SUNXI >> so that we get back some extra room for user customisations. > > Does this disable it on aarch64 boards by default such as the Pine64? > If so NAK as Fedora, SUSE and I'm pretty sure Debian all use EFI to > boot aarch64 devices and this would regress this for all those > distros. > > Peter > Debian uses package flash-kernel by default. Flash-kernel generates a new boot.scr script every time you install a new kernel. Packages grub-efi-arm and grub-efi-arm64 are provided for those who prefer to boot their ARM board via EFI. All sunxi boards use SPL=y. So why should there be a size limit crossed? Is there an unsuitable limit built in to the second stage boot loader? Then this should be fixed instead of castrating the configuration. Heinrich >> Signed-off-by: Maxime Ripard >> --- >> lib/efi_loader/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig >> index d2b6327119b4..a80a914b2fe8 100644 >> --- a/lib/efi_loader/Kconfig >> +++ b/lib/efi_loader/Kconfig >> @@ -1,7 +1,7 @@ >> config EFI_LOADER >> bool "Support running EFI Applications in U-Boot" >> depends on (ARM || X86) && OF_LIBFDT >> - default y >> + default y if !ARCH_SUNXI >> help >> Select this option if you want to run EFI applications (like grub2) >> on top of U-Boot. If this option is enabled, U-Boot will expose EFI >> -- >> 2.14.2 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot at lists.denx.de >> https://lists.denx.de/listinfo/u-boot > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot >