From: Eric Blake <eblake@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific
Date: Tue, 1 May 2018 08:01:58 -0500 [thread overview]
Message-ID: <115942c3-ac74-7cc2-6683-98a6dffc7d6c@redhat.com> (raw)
In-Reply-To: <20180430065235.577-1-aik@ozlabs.ru>
On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote:
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
There is no rationale in the commit body (a good commit message has a
one-line summary of "what", then a paragraph stating "why", making it
easier for the reviewer to check that the patch itself is the "how" that
matches the commit message).
Also, when sending a new patch, it's best to send it as a new top-level
thread, rather than in-reply-to an older thread that has already seen
review commentary (otherwise, it's likely to get missed in the noise).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-01 13:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 0:25 [Qemu-devel] [PATCH qemu v4 0/2] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-03-03 0:25 ` [Qemu-devel] [PATCH qemu v4 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo Alexey Kardashevskiy
2018-04-18 16:35 ` Eric Blake
2018-04-30 10:04 ` Paolo Bonzini
2018-03-03 0:25 ` [Qemu-devel] [PATCH qemu v4 2/2] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-04-13 14:16 ` Markus Armbruster
2018-04-30 6:52 ` [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific Alexey Kardashevskiy
2018-04-30 6:56 ` no-reply
2018-04-30 7:07 ` Alexey Kardashevskiy
2018-04-30 6:58 ` no-reply
2018-04-30 7:00 ` no-reply
2018-04-30 9:39 ` Paolo Bonzini
2018-05-02 1:26 ` Alexey Kardashevskiy
2018-05-02 6:34 ` Markus Armbruster
2018-05-02 9:11 ` Paolo Bonzini
2018-05-02 9:33 ` Alexey Kardashevskiy
2018-05-02 9:50 ` Paolo Bonzini
2018-05-03 6:22 ` Alexey Kardashevskiy
2018-05-03 10:54 ` Paolo Bonzini
2018-05-02 9:38 ` Markus Armbruster
2018-05-02 9:47 ` Paolo Bonzini
2018-05-02 12:36 ` Markus Armbruster
2018-05-02 12:42 ` Paolo Bonzini
2018-05-02 13:31 ` Markus Armbruster
2018-05-02 13:32 ` Paolo Bonzini
2018-05-01 13:01 ` Eric Blake [this message]
2018-05-02 1:33 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115942c3-ac74-7cc2-6683-98a6dffc7d6c@redhat.com \
--to=eblake@redhat.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.