From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH libdrm v2 04/10] xf86drm: Allocate drmDevicePtr's on stack Date: Fri, 29 Jun 2018 17:49:47 +0200 Message-ID: <1161b785-3e45-1702-0bc2-da568d399206@collabora.com> References: <20180625173626.8046-4-emil.l.velikov@gmail.com> <20180629152017.29843-1-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A5D989229 for ; Fri, 29 Jun 2018 15:49:51 +0000 (UTC) In-Reply-To: <20180629152017.29843-1-emil.l.velikov@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org TEdUTQoKT24gMjAxOC0wNi0yOSAxNzoyMCwgRW1pbCBWZWxpa292IHdyb3RlOgo+IEZyb206IEVt aWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gCj4gQ3VycmVudGx5IHdl IGR5bmFtaWNhbGx5IGFsbG9jYXRlIDE2IHBvaW50ZXJzIGFuZCByZWFsbG9jYXRlIG1vcmUgYXMK PiBuZWVkZWQuCj4gCj4gSW5zdGVhZCwgYWxsb2NhdGUgdGhlIG1heGltdW0gbnVtYmVyICgyNTYp IG9uIHN0YWNrIC0gdGhlIG51bWJlciBpcwo+IHNtYWxsIGVub3VnaCBhbmQgaXMgdW5saWtlbHkg dG8gY2hhbmdlIGluIHRoZSBmb3Jlc2VlYWJsZSBmdXR1cmUuCj4gCj4gVGhpcyBhbGxvd3MgdXMg dG8gc2ltcGxpZnkgdGhlIGVycm9yIGhhbmRsaW5nIGFuZCBldmVuIHNoZWQgYSBmZXcgYnl0ZXMK PiBvZmYgdGhlIGZpbmFsIGJpbmFyeS4KPiAKPiB2MjoKPiAgIC0gYWRkIGEgZGVmaW5lICYgZGVz Y3JpcHRpb24gYmVoaW5kIHRoZSBtYWdpYyAyNTYgKFJvYikKPiAgIC0gcmVwb3J0IGVycm9yIHRv IHN0cmVyciBhbmQgc2tpcCB3aGVuIG92ZXIgMjU2IGRldmljZSBub2RlcyAoUm9iKQo+IAo+IENj OiBSb2JlcnQgRm9zcyA8cm9iZXJ0LmZvc3NAY29sbGFib3JhLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBFbWlsIFZlbGlrb3YgPGVtaWwudmVsaWtvdkBjb2xsYWJvcmEuY29tPgo+IFRlc3RlZC1ieTog Um9iZXJ0IEZvc3MgPHJvYmVydC5mb3NzQGNvbGxhYm9yYS5jb20+ICh2MSkKPiBSZXZpZXdlZC1i eTogUm9iZXJ0IEZvc3MgPHJvYmVydC5mb3NzQGNvbGxhYm9yYS5jb20+ICh2MSkKPiBSZXZpZXdl ZC1ieTogRXJpYyBFbmdlc3Ryb20gPGVyaWNAZW5nZXN0cm9tLmNoPiAodjEpCj4gLS0tCj4gICB4 Zjg2ZHJtLmMgfCA3OSArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgNTYgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3hmODZkcm0uYyBiL3hmODZkcm0uYwo+IGluZGV4 IDExNGNmODU1Li4wMmRhM2UxZiAxMDA2NDQKPiAtLS0gYS94Zjg2ZHJtLmMKPiArKysgYi94Zjg2 ZHJtLmMKPiBAQCAtMzc2Niw2ICszNzY2LDEzIEBAIGRybV9kZXZpY2VfaGFzX3JkZXYoZHJtRGV2 aWNlUHRyIGRldmljZSwgZGV2X3QgZmluZF9yZGV2KQo+ICAgICAgIHJldHVybiBmYWxzZTsKPiAg IH0KPiAgIAo+ICsvKgo+ICsgKiBUaGUga2VybmVsIGRybSBjb3JlIGhhcyBhIG51bWJlciBvZiBw bGFjZXMgdGhhdCBhc3N1bWUgbWF4aW11bSBvZgo+ICsgKiAzeDY0IGRldmljZXMgbm9kZXMuIFRo YXQncyA2NCBmb3IgZWFjaCBvZiBwcmltYXJ5LCBjb250cm9sIGFuZAo+ICsgKiByZW5kZXIgbm9k ZXMuIFJvdW5kZWQgaXQgdXAgdG8gMjU2IGZvciBzaW1wbGljaXR5Lgo+ICsgKi8KPiArI2RlZmlu ZSBNQVhfRFJNX05PREVTIDI1Ngo+ICsKPiAgIC8qKgo+ICAgICogR2V0IGluZm9ybWF0aW9uIGFi b3V0IHRoZSBvcGVuZWQgZHJtIGRldmljZQo+ICAgICoKPiBAQCAtMzg0Niw3ICszODUzLDcgQEAg aW50IGRybUdldERldmljZTIoaW50IGZkLCB1aW50MzJfdCBmbGFncywgZHJtRGV2aWNlUHRyICpk ZXZpY2UpCj4gICAKPiAgICAgICByZXR1cm4gMDsKPiAgICNlbHNlCj4gLSAgICBkcm1EZXZpY2VQ dHIgKmxvY2FsX2RldmljZXM7Cj4gKyAgICBkcm1EZXZpY2VQdHIgbG9jYWxfZGV2aWNlc1tNQVhf RFJNX05PREVTXTsKPiAgICAgICBkcm1EZXZpY2VQdHIgZDsKPiAgICAgICBESVIgKnN5c2RpcjsK PiAgICAgICBzdHJ1Y3QgZGlyZW50ICpkZW50Owo+IEBAIC0zODU0LDcgKzM4NjEsNiBAQCBpbnQg ZHJtR2V0RGV2aWNlMihpbnQgZmQsIHVpbnQzMl90IGZsYWdzLCBkcm1EZXZpY2VQdHIgKmRldmlj ZSkKPiAgICAgICBpbnQgc3Vic3lzdGVtX3R5cGU7Cj4gICAgICAgaW50IG1haiwgbWluOwo+ICAg ICAgIGludCByZXQsIGksIG5vZGVfY291bnQ7Cj4gLSAgICBpbnQgbWF4X2NvdW50ID0gMTY7Cj4g ICAgICAgZGV2X3QgZmluZF9yZGV2Owo+ICAgCj4gICAgICAgaWYgKGRybV9kZXZpY2VfdmFsaWRh dGVfZmxhZ3MoZmxhZ3MpKQo+IEBAIC0zODc3LDE1ICszODgzLDkgQEAgaW50IGRybUdldERldmlj ZTIoaW50IGZkLCB1aW50MzJfdCBmbGFncywgZHJtRGV2aWNlUHRyICpkZXZpY2UpCj4gICAgICAg aWYgKHN1YnN5c3RlbV90eXBlIDwgMCkKPiAgICAgICAgICAgcmV0dXJuIHN1YnN5c3RlbV90eXBl Owo+ICAgCj4gLSAgICBsb2NhbF9kZXZpY2VzID0gY2FsbG9jKG1heF9jb3VudCwgc2l6ZW9mKGRy bURldmljZVB0cikpOwo+IC0gICAgaWYgKGxvY2FsX2RldmljZXMgPT0gTlVMTCkKPiAtICAgICAg ICByZXR1cm4gLUVOT01FTTsKPiAtCj4gICAgICAgc3lzZGlyID0gb3BlbmRpcihEUk1fRElSX05B TUUpOwo+IC0gICAgaWYgKCFzeXNkaXIpIHsKPiAtICAgICAgICByZXQgPSAtZXJybm87Cj4gLSAg ICAgICAgZ290byBmcmVlX2xvY2FsczsKPiAtICAgIH0KPiArICAgIGlmICghc3lzZGlyKQo+ICsg ICAgICAgIHJldHVybiAtZXJybm87Cj4gICAKPiAgICAgICBpID0gMDsKPiAgICAgICB3aGlsZSAo KGRlbnQgPSByZWFkZGlyKHN5c2RpcikpKSB7Cj4gQEAgLTM4OTMsMTYgKzM4OTMsMTIgQEAgaW50 IGRybUdldERldmljZTIoaW50IGZkLCB1aW50MzJfdCBmbGFncywgZHJtRGV2aWNlUHRyICpkZXZp Y2UpCj4gICAgICAgICAgIGlmIChyZXQpCj4gICAgICAgICAgICAgICBjb250aW51ZTsKPiAgIAo+ IC0gICAgICAgIGlmIChpID49IG1heF9jb3VudCkgewo+IC0gICAgICAgICAgICBkcm1EZXZpY2VQ dHIgKnRlbXA7Cj4gLQo+IC0gICAgICAgICAgICBtYXhfY291bnQgKz0gMTY7Cj4gLSAgICAgICAg ICAgIHRlbXAgPSByZWFsbG9jKGxvY2FsX2RldmljZXMsIG1heF9jb3VudCAqIHNpemVvZihkcm1E ZXZpY2VQdHIpKTsKPiAtICAgICAgICAgICAgaWYgKCF0ZW1wKQo+IC0gICAgICAgICAgICAgICAg Z290byBmcmVlX2RldmljZXM7Cj4gLSAgICAgICAgICAgIGxvY2FsX2RldmljZXMgPSB0ZW1wOwo+ ICsgICAgICAgIGlmIChpID49IE1BWF9EUk1fTk9ERVMpIHsKPiArICAgICAgICAgICAgZnByaW50 ZihzdGRlcnIsICJNb3JlIHRoYW4gJWQgZHJtIG5vZGVzIGRldGVjdGVkLiAiCj4gKyAgICAgICAg ICAgICAgICAgICAgIlBsZWFzZSByZXBvcnQgYSBidWcgLSB0aGF0IHNob3VsZCBub3QgaGFwcGVu LlxuIgo+ICsgICAgICAgICAgICAgICAgICAgICJTa2lwcGluZyBleHRyYSBub2Rlc1xuIiwgTUFY X0RSTV9OT0RFUyk7Cj4gKyAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgICB9Cj4gLQo+ICAg ICAgICAgICBsb2NhbF9kZXZpY2VzW2ldID0gZDsKPiAgICAgICAgICAgaSsrOwo+ICAgICAgIH0K PiBAQCAtMzkyMSwxOCArMzkxNyw5IEBAIGludCBkcm1HZXREZXZpY2UyKGludCBmZCwgdWludDMy X3QgZmxhZ3MsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ICAgICAgIH0KPiAgIAo+ICAgICAgIGNs b3NlZGlyKHN5c2Rpcik7Cj4gLSAgICBmcmVlKGxvY2FsX2RldmljZXMpOwo+ICAgICAgIGlmICgq ZGV2aWNlID09IE5VTEwpCj4gICAgICAgICAgIHJldHVybiAtRU5PREVWOwo+ICAgICAgIHJldHVy biAwOwo+IC0KPiAtZnJlZV9kZXZpY2VzOgo+IC0gICAgZHJtRnJlZURldmljZXMobG9jYWxfZGV2 aWNlcywgaSk7Cj4gLSAgICBjbG9zZWRpcihzeXNkaXIpOwo+IC0KPiAtZnJlZV9sb2NhbHM6Cj4g LSAgICBmcmVlKGxvY2FsX2RldmljZXMpOwo+IC0gICAgcmV0dXJuIHJldDsKPiAgICNlbmRpZgo+ ICAgfQo+ICAgCj4gQEAgLTM5NjgsMjUgKzM5NTUsMTggQEAgaW50IGRybUdldERldmljZShpbnQg ZmQsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ICAgICovCj4gICBpbnQgZHJtR2V0RGV2aWNlczIo dWludDMyX3QgZmxhZ3MsIGRybURldmljZVB0ciBkZXZpY2VzW10sIGludCBtYXhfZGV2aWNlcykK PiAgIHsKPiAtICAgIGRybURldmljZVB0ciAqbG9jYWxfZGV2aWNlczsKPiArICAgIGRybURldmlj ZVB0ciBsb2NhbF9kZXZpY2VzW01BWF9EUk1fTk9ERVNdOwo+ICAgICAgIGRybURldmljZVB0ciBk ZXZpY2U7Cj4gICAgICAgRElSICpzeXNkaXI7Cj4gICAgICAgc3RydWN0IGRpcmVudCAqZGVudDsK PiAgICAgICBpbnQgcmV0LCBpLCBub2RlX2NvdW50LCBkZXZpY2VfY291bnQ7Cj4gLSAgICBpbnQg bWF4X2NvdW50ID0gMTY7Cj4gICAKPiAgICAgICBpZiAoZHJtX2RldmljZV92YWxpZGF0ZV9mbGFn cyhmbGFncykpCj4gICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICAgCj4gLSAgICBsb2NhbF9k ZXZpY2VzID0gY2FsbG9jKG1heF9jb3VudCwgc2l6ZW9mKGRybURldmljZVB0cikpOwo+IC0gICAg aWYgKGxvY2FsX2RldmljZXMgPT0gTlVMTCkKPiAtICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAt Cj4gICAgICAgc3lzZGlyID0gb3BlbmRpcihEUk1fRElSX05BTUUpOwo+IC0gICAgaWYgKCFzeXNk aXIpIHsKPiAtICAgICAgICByZXQgPSAtZXJybm87Cj4gLSAgICAgICAgZ290byBmcmVlX2xvY2Fs czsKPiAtICAgIH0KPiArICAgIGlmICghc3lzZGlyKQo+ICsgICAgICAgIHJldHVybiAtZXJybm87 Cj4gICAKPiAgICAgICBpID0gMDsKPiAgICAgICB3aGlsZSAoKGRlbnQgPSByZWFkZGlyKHN5c2Rp cikpKSB7Cj4gQEAgLTM5OTQsMTYgKzM5NzQsMTIgQEAgaW50IGRybUdldERldmljZXMyKHVpbnQz Ml90IGZsYWdzLCBkcm1EZXZpY2VQdHIgZGV2aWNlc1tdLCBpbnQgbWF4X2RldmljZXMpCj4gICAg ICAgICAgIGlmIChyZXQpCj4gICAgICAgICAgICAgICBjb250aW51ZTsKPiAgIAo+IC0gICAgICAg IGlmIChpID49IG1heF9jb3VudCkgewo+IC0gICAgICAgICAgICBkcm1EZXZpY2VQdHIgKnRlbXA7 Cj4gLQo+IC0gICAgICAgICAgICBtYXhfY291bnQgKz0gMTY7Cj4gLSAgICAgICAgICAgIHRlbXAg PSByZWFsbG9jKGxvY2FsX2RldmljZXMsIG1heF9jb3VudCAqIHNpemVvZihkcm1EZXZpY2VQdHIp KTsKPiAtICAgICAgICAgICAgaWYgKCF0ZW1wKQo+IC0gICAgICAgICAgICAgICAgZ290byBmcmVl X2RldmljZXM7Cj4gLSAgICAgICAgICAgIGxvY2FsX2RldmljZXMgPSB0ZW1wOwo+ICsgICAgICAg IGlmIChpID49IE1BWF9EUk1fTk9ERVMpIHsKPiArICAgICAgICAgICAgZnByaW50ZihzdGRlcnIs ICJNb3JlIHRoYW4gJWQgZHJtIG5vZGVzIGRldGVjdGVkLiAiCj4gKyAgICAgICAgICAgICAgICAg ICAgIlBsZWFzZSByZXBvcnQgYSBidWcgLSB0aGF0IHNob3VsZCBub3QgaGFwcGVuLlxuIgo+ICsg ICAgICAgICAgICAgICAgICAgICJTa2lwcGluZyBleHRyYSBub2Rlc1xuIiwgTUFYX0RSTV9OT0RF Uyk7Cj4gKyAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgICB9Cj4gLQo+ICAgICAgICAgICBs b2NhbF9kZXZpY2VzW2ldID0gZGV2aWNlOwo+ICAgICAgICAgICBpKys7Cj4gICAgICAgfQo+IEBA IC00MDI1LDE2ICs0MDAxLDcgQEAgaW50IGRybUdldERldmljZXMyKHVpbnQzMl90IGZsYWdzLCBk cm1EZXZpY2VQdHIgZGV2aWNlc1tdLCBpbnQgbWF4X2RldmljZXMpCj4gICAgICAgfQo+ICAgCj4g ICAgICAgY2xvc2VkaXIoc3lzZGlyKTsKPiAtICAgIGZyZWUobG9jYWxfZGV2aWNlcyk7Cj4gICAg ICAgcmV0dXJuIGRldmljZV9jb3VudDsKPiAtCj4gLWZyZWVfZGV2aWNlczoKPiAtICAgIGRybUZy ZWVEZXZpY2VzKGxvY2FsX2RldmljZXMsIGkpOwo+IC0gICAgY2xvc2VkaXIoc3lzZGlyKTsKPiAt Cj4gLWZyZWVfbG9jYWxzOgo+IC0gICAgZnJlZShsb2NhbF9kZXZpY2VzKTsKPiAtICAgIHJldHVy biByZXQ7Cj4gICB9Cj4gICAKPiAgIC8qKgo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK