From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759697AbbA0URJ (ORCPT ); Tue, 27 Jan 2015 15:17:09 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:60721 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755658AbbA0URG (ORCPT ); Tue, 27 Jan 2015 15:17:06 -0500 From: Arnd Bergmann To: Zubair Lutfullah Kakakhel Cc: wim@iguana.be, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, paul@crapouillou.net Subject: Re: [PATCH 1/2] dt: watchdog: Add DT binding documentation for jz47xx watchdog timer Date: Tue, 27 Jan 2015 21:16:45 +0100 Message-ID: <11680810.808F8uDyN0@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1422371490-44402-2-git-send-email-Zubair.Kakakhel@imgtec.com> References: <1422371490-44402-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1422371490-44402-2-git-send-email-Zubair.Kakakhel@imgtec.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Db6v1cTcJPOTwmWVdok7q2JyVScCy+prz8VeUFXYtSo6iy/3XKs NSE+qs7kVf1iPHedcialTbOSv2KdGoMZj0FjDLSLIDb/WwDNJmpj9t5mqcvaqz/AXjI1tUs l/02pAdJ6EQLV4QLZZiwAnuzVQBWo/+fennCg40fdlcDCkqoVTAcXSySQJGsD3o4JFQwoYT dtwqmFXy/dKX9RldCIZjg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 27 January 2015 15:11:29 Zubair Lutfullah Kakakhel wrote: > +clocks: phandle to rtcclk > +clock-names: must be "rtc" > + > +Example: > + > +watchdog: jz47xx-watchdog@0x10002000 { > + compatible = "ingenic,jz4780-watchdog"; > + reg = <0x10002000 0x100>; > + > + clocks = <&rtclk>; > + clock-names = "rtc"; > +}; Why is the name "rtc"? are you sure you are not confusing the output name of the clock controller with the input of the watchdog device? It's suspicious that both have similar names. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/2] dt: watchdog: Add DT binding documentation for jz47xx watchdog timer Date: Tue, 27 Jan 2015 21:16:45 +0100 Message-ID: <11680810.808F8uDyN0@wuerfel> References: <1422371490-44402-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1422371490-44402-2-git-send-email-Zubair.Kakakhel@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1422371490-44402-2-git-send-email-Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Zubair Lutfullah Kakakhel Cc: wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org List-Id: devicetree@vger.kernel.org On Tuesday 27 January 2015 15:11:29 Zubair Lutfullah Kakakhel wrote: > +clocks: phandle to rtcclk > +clock-names: must be "rtc" > + > +Example: > + > +watchdog: jz47xx-watchdog@0x10002000 { > + compatible = "ingenic,jz4780-watchdog"; > + reg = <0x10002000 0x100>; > + > + clocks = <&rtclk>; > + clock-names = "rtc"; > +}; Why is the name "rtc"? are you sure you are not confusing the output name of the clock controller with the input of the watchdog device? It's suspicious that both have similar names. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html