From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbcIAJ75 (ORCPT ); Thu, 1 Sep 2016 05:59:57 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56714 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbcIAJ7z (ORCPT ); Thu, 1 Sep 2016 05:59:55 -0400 X-AuditID: cbfee61a-f78ff6d000001462-fb-57c7fc19ee26 From: Bartlomiej Zolnierkiewicz To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland Subject: Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Date: Thu, 01 Sep 2016 11:59:48 +0200 Message-id: <11690712.d89FASKYvI@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <21e643af-bff7-2563-0254-d2b6e4a9a385@osg.samsung.com> References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <12377780.GCreFUiXAa@amdc1976> <21e643af-bff7-2563-0254-d2b6e4a9a385@osg.samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t9jAV3JP8fDDabPlbOYf+Qcq8Wbt2uY LPofv2a2OH9+A7vF5V1z2CxmnN/HZLH0+kUmi9a9R9gdODzWzFvD6LFpVSebx5b+u+wenzfJ BbBEcdmkpOZklqUW6dslcGVcPN3AWNAsXDFr/UHWBsYffF2MnBwSAiYSS5pXskHYYhIX7q0H s4UEljJK/L0a0sXIBWR/ZZSYdeA4I0iCTcBKYmL7KjBbRMBU4tfaF6wgRcwCnxglzv96zQKS EBbIkJj4/BKYzSKgKnF94lWmLkYODl4BLYln3/VAwqICXhI92x+BzeEUcJbYsugVK8Sy+YwS 905/ZwJJ8AoISvyYfA9sDrOAvMS+/VNZIWwtifU7jzNNYBSYhaRsFpKyWUjKFjAyr2KUSC1I LihOSs81zEst1ytOzC0uzUvXS87P3cQIDvZnUjsYD+5yP8QowMGoxMPrFXg8XIg1say4MvcQ owQHs5II77rvQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8j/+vCxMSSE8sSc1OTS1ILYLJMnFw SjUw2nz8Jm+qYSW/9Hoc7++jt0/9Zmv6+CyeheeXtPOZQ9NyH29WOSyf63FvdeFK7WjOvgvX WSU2THErdr5wXY5tm7j4/wWLIrW+nTzh+zH+vFmC6A6N2AvKGepr+vK9BPd4Osj9tol/cH37 xc0vWvM5twsUrNu1WlVNpmS6GbPLwzPR72aeFd1wSImlOCPRUIu5qDgRAEbyfKFyAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday, September 01, 2016 10:35:15 AM Javier Martinez Canillas wrote: > Hello Bartlomiej, > > On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote: > >> Hello Krzysztof, > >> > >> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote: > >>> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote: > >>>> Hello Krzysztof, > >>>> > >>>> This series removes the usage of the skeleton.dtsi in all the Exynos dts, > >>>> which allows to get rid of the DTC warnings about a mismatch between the > >>>> memory nodes' unit names and reg properties. > >>>> > >>>> Patches are pretty trivial and shouldn't cause functional changes AFAIK, > >>>> but only the Exynos5 changes have been tested. The others patches were > >>>> just built tested. > >>> > >>> I think this is a common problem, not only Exynos-specific, so I would > >> > >> That's correct. > >> > >>> prefer to stick to common pattern. Either all DTS/DTSI include skeleton > >>> or none of them. > >>> > >> > >> The idea is to get rid of skeleton.dtsi [0], but that will of course take > >> time until the dtsi is removed from all the files. So this patch is a step > >> in the right direction so at least Exynos is not a blocker to remove it. > > > > Krzysztof's point is valid. If you are going to convert all DTS/DTSI > > then it is okay to apply Exynos specific changes, otherwise the code > > should stay as it is currently. > > > > Exynos won't be a blocker since we have your patches now and they can > > be applied when/if needed ;).. > > > > Sorry but I disagree. I see no reasons to need this to be an atomic, rather > than incremental change. Deprecated things are usually handled by removing > the usage and once there are no users, finally removing them. Yes, given that there is agreement on the direction and people are aware of the needed changes. This doesn't seem to be a case yet as there is no comment in skeleton.dtsi about being deprecated and other platforms' Maintainers are not aware of the need for the change. > Also, each subsystem maintainer should carry the patches for their platform > so it can't be a kernel wide change anyways and most likely split by kernel > releases. Yep. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics