From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6073CC4338F for ; Thu, 5 Aug 2021 16:22:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAF2060EE5 for ; Thu, 5 Aug 2021 16:22:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BAF2060EE5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CE7C882EEC; Thu, 5 Aug 2021 18:21:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="h6OG6qqG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B75282E83; Thu, 5 Aug 2021 18:21:37 +0200 (CEST) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6EEB88262E for ; Thu, 5 Aug 2021 18:21:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wr1-x42c.google.com with SMTP id h14so7290143wrx.10 for ; Thu, 05 Aug 2021 09:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fa0bCi+nMZwdvl0JGiq/xnCLA8kHcEM6oi2gZrLXVJ0=; b=h6OG6qqGzsM4Ubg3o/euTlVPPtdQ+nBTnAS3ZTOEQ6EVYGEmJ7MPUxtUqMGzWIExsR sxwDu05Ifbr/CNwGWcyEOX+Zl59EHU4C6a/ZuMm1Rq0geqKMh8F1Mc9e+v+SX+fcstrK kpsJoIne8kB9rhqqrNjQeYGncO4tEGYhm0a/x+uliotnMB8kmOPUno+RjrZDpghd6iDb EKKE+OSuw4vmbhjq4+1EE2quZBPYNXA9XgS4GCHwdJNdyxjAmlA/uWa8nHErv+Tf0YwK yd8ZHab/lAb8qGS+sQSdF7mAfYJ00zFaRfvg9hwF+US+0MfIk1EikgMWTgiKWAfB5xwH BfOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fa0bCi+nMZwdvl0JGiq/xnCLA8kHcEM6oi2gZrLXVJ0=; b=XPz3SGfFW8OCJoySEhd1YLALRUWoL3nbNiAEy45lWzfbSn27il2Edfc0YhSGNh24uW kJEDoeAQKD7atSKdelSZuN6i6e5ejzkhsl7n1k5eO3g3CqeOxE1jYrBivBblYHMOaYSI nQ0d52k9b949k+iC4BAA64ie1T/YnH6Th/mqhx3npETu/dW+AFGIe8tCZ0qu0TZhoItq KR1pMZn7pTxhK8gynQb+VOpIqW/prXQK9U+DxFp/JCY1/1fkRTphhYmoADXnOOM+IrmG v+sx4iCZ3RrFdl8YriAeNjL2OL0/Wg5w1eCaE6PeqZSEwagSXJOfYxVpabpBbbAbSnFt /y/A== X-Gm-Message-State: AOAM531gjyU556gXoGnjM2cPofWM7cv/jDL569ffDwrN928FXf3Bh3JK mDrf9xyTh+XvwZe777BVISPWSQz5VFN2uA== X-Google-Smtp-Source: ABdhPJy0Btd5STz++sFEQLbxAFxniP1OrOsvtGj2kJsuPpBamgB90DEZz0D548O3DuUrqiOx1GOeMA== X-Received: by 2002:a5d:5644:: with SMTP id j4mr6504782wrw.66.1628180483666; Thu, 05 Aug 2021 09:21:23 -0700 (PDT) Received: from [192.168.1.104] ([37.165.211.117]) by smtp.gmail.com with ESMTPSA id f2sm6703547wrq.69.2021.08.05.09.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 09:21:23 -0700 (PDT) Subject: Re: [PATCH 8/9] configs: sei510/sei610: don't use hard-coded gpt uuids To: Mattijs Korpershoek Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de References: <20210805151728.422329-1-mkorpershoek@baylibre.com> <20210805151728.422329-9-mkorpershoek@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <1169860d-7030-fb83-bb48-5dc47ad908a3@baylibre.com> Date: Thu, 5 Aug 2021 18:21:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210805151728.422329-9-mkorpershoek@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 05/08/2021 17:17, Mattijs Korpershoek wrote: > doc/README.gpt states: > >> The fields 'uuid' and 'uuid_disk' are optional if CONFIG_RANDOM_UUID is >> enabled. A random uuid will be used if omitted or they point to an empty/ >> non-existent environment variable. The environment variable will be >> set to the generated UUID. The 'gpt guid' command reads the current >> value of the uuid_disk from the GPT. > > Since we have CONFIG_RANDOM_UUID=y, remove the hard-coded uuids > and use meaningful variable names instead. > > Signed-off-by: Mattijs Korpershoek > --- > include/configs/sei510.h | 12 ++++-------- > include/configs/sei610.h | 12 ++++-------- > 2 files changed, 8 insertions(+), 16 deletions(-) > > diff --git a/include/configs/sei510.h b/include/configs/sei510.h > index 16a34c717d..5bf2668803 100644 > --- a/include/configs/sei510.h > +++ b/include/configs/sei510.h > @@ -10,20 +10,16 @@ > #define __CONFIG_H > > #define LOGO_UUID "43a3305d-150f-4cc9-bd3b-38fca8693846;" > -#define CACHE_UUID "99207ae6-5207-11e9-999e-6f77a3612069;" > -#define SYSTEM_UUID "99f9b7ac-5207-11e9-8507-c3c037e393f3;" > -#define VENDOR_UUID "9d082802-5207-11e9-954c-cbbce08ba108;" > -#define USERDATA_UUID "9b976e42-5207-11e9-8f16-ff47ac594b22;" > #define ROOT_UUID "ddb8c3f6-d94d-4394-b633-3134139cc2e0;" > > #define PARTS_DEFAULT \ > "uuid_disk=${uuid_gpt_disk};" \ > "name=boot,size=64M,bootable,uuid=${uuid_gpt_boot};" \ > "name=logo,size=2M,uuid=" LOGO_UUID \ > - "name=cache,size=256M,uuid=" CACHE_UUID \ > - "name=system,size=1536M,uuid=" SYSTEM_UUID \ > - "name=vendor,size=256M,uuid=" VENDOR_UUID \ > - "name=userdata,size=5341M,uuid=" USERDATA_UUID \ > + "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ > + "name=system,size=1536M,uuid=${uuid_gpt_system};" \ > + "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ > + "name=userdata,size=5341M,uuid={uuid_gpt_userdata};" \ > "name=rootfs,size=-,uuid=" ROOT_UUID > > > diff --git a/include/configs/sei610.h b/include/configs/sei610.h > index 6d13fd143b..baace75a02 100644 > --- a/include/configs/sei610.h > +++ b/include/configs/sei610.h > @@ -10,20 +10,16 @@ > #define __CONFIG_H > > #define LOGO_UUID "43a3305d-150f-4cc9-bd3b-38fca8693846;" > -#define CACHE_UUID "99207ae6-5207-11e9-999e-6f77a3612069;" > -#define SYSTEM_UUID "99f9b7ac-5207-11e9-8507-c3c037e393f3;" > -#define VENDOR_UUID "9d082802-5207-11e9-954c-cbbce08ba108;" > -#define USERDATA_UUID "9b976e42-5207-11e9-8f16-ff47ac594b22;" > #define ROOT_UUID "ddb8c3f6-d94d-4394-b633-3134139cc2e0;" > > #define PARTS_DEFAULT \ > "uuid_disk=${uuid_gpt_disk};" \ > "name=boot,size=64M,bootable,uuid=${uuid_gpt_boot};" \ > "name=logo,size=2M,uuid=" LOGO_UUID \ > - "name=cache,size=256M,uuid=" CACHE_UUID \ > - "name=system,size=1536M,uuid=" SYSTEM_UUID \ > - "name=vendor,size=256M,uuid=" VENDOR_UUID \ > - "name=userdata,size=12795M,uuid=" USERDATA_UUID \ > + "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ > + "name=system,size=1536M,uuid=${uuid_gpt_system};" \ > + "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ > + "name=userdata,size=12795M,uuid=${uuid_gpt_userdata};" \ > "name=rootfs,size=-,uuid=" ROOT_UUID > > #include > Acked-by: Neil Armstrong