Re: [PATCH] Added QE to the list of default scanned OF devices

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andy Fleming <afleming@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Added QE to the list of default scanned OF devices
Date: Fri, 09 Feb 2007 09:27:47 +1100	[thread overview]
Message-ID: <1170973667.2620.376.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.61.0702081056250.15256@ld0175-tx32.am.freescale.net>

On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> ---
>  arch/powerpc/kernel/of_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.

Ben.

> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
> index b734517..43c5a00 100644
> --- a/arch/powerpc/kernel/of_platform.c
> +++ b/arch/powerpc/kernel/of_platform.c
> @@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
>  	{ .type = "plb4", },
>  	{ .type = "opb", },
>  	{ .type = "ebc", },
> +	{ .type = "qe", },
>  	{},
>  };
>  