From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haiying Wang Date: Fri, 09 Feb 2007 14:48:03 -0500 Subject: [U-Boot-Users] [PATCH0/2] Re-do the patch for adding DO_SYNC in flash_write_cmd In-Reply-To: <20070209194200.237A535265F@atlas.denx.de> References: <20070209194200.237A535265F@atlas.denx.de> Message-ID: <1171050483.3932.31.camel@udp097531uds.am.freescale.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de SYNC is defined as " #define SYNC \ sync; \ isync " in include/ppc_asm.tmpl, and can not be used by .c file, am I right? :-). In fact it is used by the start.S file for 85xx/83xx/8xx/4xx/5xxx/74xx_7xx. We need to define SYNC as asm("sync;"). Haiying On Fri, 2007-02-09 at 20:42 +0100, Wolfgang Denk wrote: > In message <1171043255.3932.20.camel@udp097531uds.am.freescale.net> you wrote: > > Because SYNC is already defined in include/ppc_asm.tmpl for some ppc > > based CPUs to use, I use DO_SYNC instead of SYNC for this patch. > > AFAICT that's a general definition which is not specific to "some ppc > based CPUs" only. Rather than redefining it why not just use this > definition? It seems to match our purposes. > > Best regards, > > Wolfgang Denk >