From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932567AbXBKXW0 (ORCPT ); Sun, 11 Feb 2007 18:22:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932576AbXBKXW0 (ORCPT ); Sun, 11 Feb 2007 18:22:26 -0500 Received: from nigel.suspend2.net ([203.171.70.205]:35016 "EHLO nigel.suspend2.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932567AbXBKXWZ (ORCPT ); Sun, 11 Feb 2007 18:22:25 -0500 Subject: Re: NAK new drivers without proper power management? From: Nigel Cunningham Reply-To: nigel@nigel.suspend2.net To: "Rafael J. Wysocki" Cc: Alan , Pavel Machek , Arjan van de Ven , LKML In-Reply-To: <200702120016.18480.rjw@sisk.pl> References: <1171058269.1484.64.camel@nigel.suspend2.net> <20070211210258.0b8da53c@localhost.localdomain> <1171235428.4493.105.camel@nigel.suspend2.net> <200702120016.18480.rjw@sisk.pl> Content-Type: text/plain Date: Mon, 12 Feb 2007 10:22:23 +1100 Message-Id: <1171236143.4493.118.camel@nigel.suspend2.net> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Mon, 2007-02-12 at 00:16 +0100, Rafael J. Wysocki wrote: > On Monday, 12 February 2007 00:10, Nigel Cunningham wrote: > > Hi. > > > > On Sun, 2007-02-11 at 21:02 +0000, Alan wrote: > > > > > "If the device requires that, implement .suspend and .resume or at least > > > > > define .suspend that will always return -ENOSYS (then people will know they > > > > > have to unload the driver before the suspend). Similarly, if you aren't sure > > > > > whether or not the device requires .suspend and .resume, define .suspend that > > > > > will always return -ENOSYS." > > > > > > > > Sounds ok to me. Where should this text go? > > > > Documentation/SubmittingDrivers ? > > > > > > And testing/submitting drivers, perhaps with additional text in that to > > > make it clear we want suspend/resume support or good excuses > > > > > > "Please verify your driver correctly handles suspend and resume. If it > > > does not your patch submission is likely to be suspended and only resume > > > when the driver correctly handles this feature" > > > > Maybe make it explicit that testing should be done for both suspend to > > ram and to disk, and with the following usage scenarios as applicable? > > > > - built in; > > - modular, loaded while suspending but not loaded prior to resume from > > disk; > > - modular, loaded while suspending and loaded prior to resume from disk; > > I think we should state the general rule in Documentation/SubmittingDrivers > and give more details in Documentation/power/devices.txt Sounds good. Regards, Nigel