All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: linux-ide@vger.kernel.org
Cc: fedora-ia64-list <fedora-ia64-list@redhat.com>
Subject: The 5th bar of ide controller at legacy mode
Date: Mon, 12 Feb 2007 09:40:53 +0800	[thread overview]
Message-ID: <1171244453.15989.389.camel@ymzhang> (raw)

Hi,

I am using Fedora Core 7 Test1 on my ia64 box and run into an issue
about my cd drive. FC6 works well on my machine, but FC7Test1 couldn't
recognise the cd drive.

I checked it and found FC6 uses ide-cd/piix drivers, while FC7Test1
replaces them with ata/ata_piix drivers. When drivers call pci_enable_device,
the calling will fail if the bar resource is incorrect.

The bar resource of the ide controller on my tiger machine:
[root@tigerF 0000:00:1f.1]# pwd
/sys/devices/pci0000:00/0000:00:1f.1
[root@tigerF 0000:00:1f.1]# cat resource
0x00000000000001f0 0x00000000000001f7 0x0000000000000110
0x00000000000003f6 0x00000000000003f6 0x0000000000000110
0x0000000000000170 0x0000000000000177 0x0000000000000110
0x0000000000000376 0x0000000000000376 0x0000000000000110
0x0000000000001000 0x000000000000100f 0x0000000000000101
0x0000000000000000 0x00000000000003ff 0x0000000000000200
0x0000000000000000 0x0000000000000000 0x0000000000000000

The 5th bar is incorrect. BIOS initiates ide controllers.

If pci_enable_device fails, ata/ata_piix drivers will report the probe
failure, but ide-cd/piix is smarter to recall pci_enable_device_bars
directly with parameter bars=(1<<4), so only 0~4th bar resources are checked.

Below is a copy of some comments of function ide_pci_enable:

 *      Enable the IDE PCI device. We attempt to enable the device in full
 *      but if that fails then we only need BAR4 so we will enable that.

>From the comments, I expect the bars (other than 4th) of ide controllers
are incorrectly innitiated by BIOS very often.

So my question is: should ata/ata_piix also need to recall pci_enable_device_bars
with parameter bars=(1<<4) if pci_enable_device fails like what ide-cd/piix does?

Yanmin

             reply	other threads:[~2007-02-12  1:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12  1:40 Zhang, Yanmin [this message]
2007-02-12 12:22 ` [Fedora-ia64-list] " Prarit Bhargava
2007-02-12 12:56 ` Alan
2007-02-12 18:18   ` [Fedora-ia64-list] " Luck, Tony
2007-02-12 18:24     ` Prarit Bhargava
2007-02-12 19:24     ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171244453.15989.389.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=fedora-ia64-list@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --subject='Re: The 5th bar of ide controller at legacy mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.