All of
 help / color / mirror / Atom feed
From: Pavel Roskin <>
To: Michael Wu <>
Cc: Jiri Benc <>,
Subject: Re: [PATCH] d80211: Fix wireless statistics reporting
Date: Sun, 11 Feb 2007 23:40:46 -0500	[thread overview]
Message-ID: <1171255246.28458.22.camel@dv> (raw)
In-Reply-To: <>

On Sun, 2007-02-11 at 23:29 -0500, Michael Wu wrote:
> On Sunday 11 February 2007 23:09, Pavel Roskin wrote:
> > > -	int signal;
> > > +	int signal; /* used as qual in statistics reporting */
> >
> > I'm sorry but that the thing I have always hated about wireless
> > extensions.  Such tricks make the API context sensitive and loaded with
> > assumptions.
> >
> Ok, but I was merely clarifying the current situation. That problem has always 
> been there since the patch for statistics reporting went in.

Sorry, I should have made it clear that my post was more a reaction to
the comments than to the actual code changes.

> > I understand d80211 still has to interact with Wireless Extensions, but
> > let's not make things even worse.
> I'm making things better. Statistics reporting is pretty bad right now in 
> d80211 with drivers reporting bogus values when they don't know, and 
> statistics reporting of different d80211 drivers interacting with each other 
> when multiple devices are plugged in. This patch attempts to fix the worst 
> issues while attempting to avoid regressions. Feel free to follow up with 
> another patch to make statistics reporting perfect.

This effort is very much appreciated.  I'll have a closer look if I see
any issues after your patch is applied.

Pavel Roskin

  reply	other threads:[~2007-02-12  4:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12  3:09 [PATCH] d80211: Fix wireless statistics reporting Michael Wu
2007-02-12  4:09 ` Pavel Roskin
2007-02-12  4:29   ` Michael Wu
2007-02-12  4:40     ` Pavel Roskin [this message]
2007-02-19 20:22 ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171255246.28458.22.camel@dv \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.