From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 6/16] Port 44x MMU definitions to ARCH=powerpc From: Benjamin Herrenschmidt To: Roland Dreier In-Reply-To: References: <20070213061024.B4A8CDDD0D@ozlabs.org> <1171347875.20192.63.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 14 Feb 2007 08:36:58 +1100 Message-Id: <1171402618.20192.100.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2007-02-13 at 09:13 -0800, Roland Dreier wrote: > > > +typedef unsigned long long phys_addr_t; > > > +extern phys_addr_t fixup_bigphys_addr(phys_addr_t, phys_addr_t); > > > +#define PHYS_FMT "%16Lx" > > > > Do we still need that fixup code ? Since we now have full 64 bits > > capable ioremap, we don't need to play tricks anymore. I'd rather get > > rid of them completely. > > Maybe make the fixup code print a warning when it actually changes an > address below 4G so we can track down all the places relying on this? Good idea. Ben.