From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 15/16] Add device tree for Ebony From: Benjamin Herrenschmidt To: Segher Boessenkool In-Reply-To: References: <20070213060904.GA6214@localhost.localdomain> <20070213061026.5837FDDDE9@ozlabs.org> <9696D7A991D0824DBA8DFAC74A9C5FA302A1B705@az33exm25.fsl.freescale.net> <1171470754.4003.101.camel@zod.rchland.ibm.com> <6206de08b7f12175bebe669291c66334@kernel.crashing.org> <20070214232246.GE16279@localhost.localdomain> <20070215015316.GL16279@localhost.localdomain> <889579906c6fd096a82283d5a3a0227e@kernel.crashing.org> <1171536722.5644.6.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 16 Feb 2007 07:43:49 +1100 Message-Id: <1171572229.5644.13.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Yoder Stuart-B08248 , David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2007-02-15 at 15:52 +0100, Segher Boessenkool wrote: > >>> No, the DCR tree, like the interrupt tree in most cases, is > >>> independent of the main tree structure. > >> > >> Yes true; you can hang the UICs from somewhere under the > >> "soc" node or whatever you want. You need some way to > >> distinguish separate identical devices though; you can't > >> do it by device unit since your devices don't have any > >> (they don't have a "reg" but only a "dcr-reg"). If you > >> would hang them in a DCR tree, you could use the plain > >> "reg" property instead of the "dcr-reg" property and > >> all would be fine (if the DCR binding allows this -- and > >> it better should, it is the standard OF addressing algorithm). > > > > It's not as DCRs are orthogonal to the normal bus tree (yeah, it sucks > > but that's how it is, broken by design :-) > > Of course, I know that. What I'm saying is that devices > where the *only* connection to the system is the DCR ring, > should use normal "reg" properties instead of "dcr-reg" > properties (and normal parent instead of "dcr-parent") to > describe the DCR registers, so that they get a valid unit > address. So you say that we shold have 2 different ways to encode a DCR mapping ? Nah .... Ben.