From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932479AbXBSSnG (ORCPT ); Mon, 19 Feb 2007 13:43:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932486AbXBSSnG (ORCPT ); Mon, 19 Feb 2007 13:43:06 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:43131 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932479AbXBSSnF (ORCPT ); Mon, 19 Feb 2007 13:43:05 -0500 Subject: Re: [PATCH 0/7] [RFC] hugetlb: pagetable_operations API From: Arjan van de Ven To: Adam Litke Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20070219183123.27318.27319.stgit@localhost.localdomain> References: <20070219183123.27318.27319.stgit@localhost.localdomain> Content-Type: text/plain Organization: Intel International BV Date: Mon, 19 Feb 2007 19:43:01 +0100 Message-Id: <1171910581.3531.89.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 (2.8.2.1-3.fc6) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > The page tables for hugetlb mappings are handled differently than page tables > for normal pages. Rather than integrating multiple page size support into the > main VM (which would tremendously complicate the code) some hooks were created. > This allows hugetlb special cases to be handled "out of line" by a separate > interface. ok it makes sense to clean this up.. what I don't like is that there STILL are all the double cases... for this to work and be worth it both the common case and the hugetlb case should be using the ops structure always! Anything else and you're just replacing bad code with bad code ;( From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 0/7] [RFC] hugetlb: pagetable_operations API From: Arjan van de Ven In-Reply-To: <20070219183123.27318.27319.stgit@localhost.localdomain> References: <20070219183123.27318.27319.stgit@localhost.localdomain> Content-Type: text/plain Date: Mon, 19 Feb 2007 19:43:01 +0100 Message-Id: <1171910581.3531.89.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Adam Litke Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > The page tables for hugetlb mappings are handled differently than page tables > for normal pages. Rather than integrating multiple page size support into the > main VM (which would tremendously complicate the code) some hooks were created. > This allows hugetlb special cases to be handled "out of line" by a separate > interface. ok it makes sense to clean this up.. what I don't like is that there STILL are all the double cases... for this to work and be worth it both the common case and the hugetlb case should be using the ops structure always! Anything else and you're just replacing bad code with bad code ;( -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org