From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932505AbXBSTbd (ORCPT ); Mon, 19 Feb 2007 14:31:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932515AbXBSTbd (ORCPT ); Mon, 19 Feb 2007 14:31:33 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:40090 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932505AbXBSTbc (ORCPT ); Mon, 19 Feb 2007 14:31:32 -0500 Subject: Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. From: Adam Litke To: Arjan van de Ven Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <1171910483.3531.87.camel@laptopd505.fenrus.org> References: <20070219183123.27318.27319.stgit@localhost.localdomain> <20070219183133.27318.92920.stgit@localhost.localdomain> <1171910483.3531.87.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Mon, 19 Feb 2007 13:31:29 -0600 Message-Id: <1171913489.22940.26.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2007-02-19 at 19:41 +0100, Arjan van de Ven wrote: > On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > > Signed-off-by: Adam Litke > > --- > > > > include/linux/mm.h | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 2d2c08d..a2fa66d 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -98,6 +98,7 @@ struct vm_area_struct { > > > > /* Function pointers to deal with this struct. */ > > struct vm_operations_struct * vm_ops; > > + struct pagetable_operations_struct * pagetable_ops; > > > > please make it at least const, those things have no business ever being > written to right? And by making them const the compiler helps catch > that, and as bonus the data gets moved to rodata so that it won't share > cachelines with anything that gets dirty Yep I agree. Changed. -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e36.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l1JJVVW1008920 for ; Mon, 19 Feb 2007 14:31:31 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l1JJVUOE495168 for ; Mon, 19 Feb 2007 12:31:30 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l1JJVUAI024789 for ; Mon, 19 Feb 2007 12:31:30 -0700 Subject: Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. From: Adam Litke In-Reply-To: <1171910483.3531.87.camel@laptopd505.fenrus.org> References: <20070219183123.27318.27319.stgit@localhost.localdomain> <20070219183133.27318.92920.stgit@localhost.localdomain> <1171910483.3531.87.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Mon, 19 Feb 2007 13:31:29 -0600 Message-Id: <1171913489.22940.26.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Arjan van de Ven Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Mon, 2007-02-19 at 19:41 +0100, Arjan van de Ven wrote: > On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > > Signed-off-by: Adam Litke > > --- > > > > include/linux/mm.h | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 2d2c08d..a2fa66d 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -98,6 +98,7 @@ struct vm_area_struct { > > > > /* Function pointers to deal with this struct. */ > > struct vm_operations_struct * vm_ops; > > + struct pagetable_operations_struct * pagetable_ops; > > > > please make it at least const, those things have no business ever being > written to right? And by making them const the compiler helps catch > that, and as bonus the data gets moved to rodata so that it won't share > cachelines with anything that gets dirty Yep I agree. Changed. -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org