Re: [PATCH 12/14] Add device tree for Ebony

[Josh Boyer <jwboyer@linux.vnet.ibm.com>]

On Tue, 2007-02-20 at 13:12 +1100, David Gibson wrote:
> Add a device tree for the Ebony evaluation board (440GP based).  This
> tree is not complete or finalized.  This tree needs a very recent
> version of dtc to process.
> 
> Signed-off-by: David Gibson <dwg@au1.ibm.com>
> ---
> 
>  arch/powerpc/boot/dts/ebony.dts |  225 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 225 insertions(+)
> 
> Index: working-2.6/arch/powerpc/boot/dts/ebony.dts
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ working-2.6/arch/powerpc/boot/dts/ebony.dts	2007-02-19 15:31:36.000000000 +1100
> @@ -0,0 +1,225 @@
> +/*
> + * Device Tree Source for IBM Ebony
> + *
> + * Copyright (c) 2006, 2007 IBM Corp.
> + * Josh Boyer <jdub@us.ibm.com>, David Gibson <dwg@au1.ibm.com>

That email address died about 2 weeks ago.  Feel free to change it to
this one: jwboyer@linux.vnet.ibm.com

> + *
> + * FIXME: Draft only!
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2.  This program is licensed "as is" without
> + * any warranty of any kind, whether express or implied.
> + *
> + * To build:
> + *   dtc -I dts -O asm -o ebony.S -b 0 -V 16 ebony.dts
> + *   dtc -I dts -O dtb -o ebony.dtb -b 0 -V 16 ebony.dts
> + */
> +
> +/ {
> +	#address-cells = <2>;
> +	#size-cells = <1>;
> +	model = "Ebony";
> +	compatible = "Ebony";
> +	dcr-parent = <&/cpus/PowerPC,440GP@0>;
> +
> +	cpus {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		PowerPC,440GP@0 {
> +			model = "440GP Rev. C";
> +			device_type = "cpu";
> +			reg = <0>;
> +			clock-frequency = <17d78400>; /* 400MHz FIXME: poke in zImage */
> +			timebase-frequency = <17d78400>; /* 400MHz FIXME: wrong, poke in zImage */
> +			i-cache-line-size = <32>;
> +			d-cache-line-size = <32>;
> +			i-cache-size = <0>;
> +			d-cache-size = <0>;
> +			dcr-controller;
> +			dcr-access-method = "native";
> +		};
> +	};
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0 00000000 08000000>; /* Set by bootwrapper */
> +	};
> +
> +	UIC0: interrupt-controller { /* UIC0 */
> +		device_type = "interrupt-controller";
> +		compatible = "ibm,uic440gp", "ibm,uic";
> +		interrupt-controller;
> +		cell-index = <0>;
> +		dcr-reg = <0c0 009>;
> +		#address-cells = <0>;
> +		#size-cells = <0>;
> +		#interrupt-cells = <2>;
> +
> +		UIC1: interrupt-controller@1 { /* UIC1 */
> +			device_type = "interrupt-controller";
> +			compatible = "ibm,uic440gp", "ibm,uic";
> +			interrupt-controller;
> +			cell-index = <1>;
> +			dcr-reg = <0d0 009>;
> +			#address-cells = <0>;
> +			#size-cells = <0>;
> +			#interrupt-cells = <2>;
> +			interrupts = <1e 4 1f 4>; /* cascade */
> +		};
> +	};
> +
> +	plb {
> +		device_type = "ibm,plb";
> +		compatible = "ibm,plb-440gp", "ibm,plb4";
> +		#address-cells = <2>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		POB0: opb@0 {

I think you meant "OPB0:" for the label.

> +			device_type = "ibm,opb";
> +			compatible = "ibm,opb-440gp", "ibm,opb";

As I pointed out in an earlier email, this breaks working with the
current legacy_serial driver.  It's looking for a device_type of "opb".
I'm not sure if we should fix the driver or fix this and the
ebony_of_bus types in arch/powerpc/platforms/4xx/ebony.c

josh