From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992428AbXCBNYA (ORCPT ); Fri, 2 Mar 2007 08:24:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992430AbXCBNX7 (ORCPT ); Fri, 2 Mar 2007 08:23:59 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:50773 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992425AbXCBNX6 (ORCPT ); Fri, 2 Mar 2007 08:23:58 -0500 Subject: Re: [RFC] Heads up on sys_fallocate() From: Dave Kleikamp To: Andrew Morton Cc: Badari Pulavarty , "Amit K. Arora" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, suparna@in.ibm.com, cmm@us.ibm.com, alex@clusterfs.com, suzuki@in.ibm.com In-Reply-To: <20070301221652.2aa3e973.akpm@linux-foundation.org> References: <20070117094658.GA17390@amitarora.in.ibm.com> <20070225022326.137b4875.akpm@linux-foundation.org> <20070301183445.GA7911@amitarora.in.ibm.com> <45E7BE4B.5070602@us.ibm.com> <20070301221652.2aa3e973.akpm@linux-foundation.org> Content-Type: text/plain Date: Fri, 02 Mar 2007 07:23:51 -0600 Message-Id: <1172841831.7992.14.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Amit wrote: > asmlinkage long sys_fallocate(int fd, loff_t offset, loff_t len); On Thu, 2007-03-01 at 22:16 -0800, Andrew Morton wrote: > On Thu, 01 Mar 2007 22:03:55 -0800 Badari Pulavarty wrote: > > > Just curious .. What does posix_fallocate() return ? > > bookmark this: > > http://www.opengroup.org/onlinepubs/009695399/nfindex.html > > Upon successful completion, posix_fallocate() shall return zero; > otherwise, an error number shall be returned to indicate the error. Then there's no need for sys_allocate to return a long. -- David Kleikamp IBM Linux Technology Center