All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: <linuxppc-dev@ozlabs.org>
Subject: [PATCH 3/6] powerpc: Move get_irq() comment into header
Date: Thu, 23 Apr 2009 11:31:38 +1000 (EST)	[thread overview]
Message-ID: <1172bff338316019112e982bafe61e862d1847a2.1240450296.git.michael@ellerman.id.au> (raw)
In-Reply-To: <c3e0e417a708c5d76d9f4130e5f2b0398a1e0c3e.1240450296.git.michael@ellerman.id.au>

The guts of do_IRQ() isn't really the right place to be documenting
the ppc_md.get_irq() interface. So move the comment into machdep.h

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/include/asm/machdep.h |    4 ++++
 arch/powerpc/kernel/irq.c          |    7 -------
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h
index 0efdb1d..11d1fc3 100644
--- a/arch/powerpc/include/asm/machdep.h
+++ b/arch/powerpc/include/asm/machdep.h
@@ -110,6 +110,10 @@ struct machdep_calls {
 	void		(*show_percpuinfo)(struct seq_file *m, int i);
 
 	void		(*init_IRQ)(void);
+
+	/* Return an irq, or NO_IRQ to indicate there are none pending.
+	 * If for some reason there is no irq, but the interrupt
+	 * shouldn't be counted as spurious, return NO_IRQ_IGNORE. */
 	unsigned int	(*get_irq)(void);
 #ifdef CONFIG_KEXEC
 	void		(*kexec_cpu_down)(int crash_shutdown, int secondary);
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index f725610..b8f09bd 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -326,13 +326,6 @@ void do_IRQ(struct pt_regs *regs)
 
 	check_stack_overflow();
 
-	/*
-	 * Every platform is required to implement ppc_md.get_irq.
-	 * This function will either return an irq number or NO_IRQ to
-	 * indicate there are no more pending.
-	 * The value NO_IRQ_IGNORE is for buggy hardware and means that this
-	 * IRQ has already been handled. -- Tom
-	 */
 	irq = ppc_md.get_irq();
 
 	if (irq != NO_IRQ && irq != NO_IRQ_IGNORE)
-- 
1.6.2.1

  parent reply	other threads:[~2009-04-23  1:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23  1:31 [PATCH 1/6] powerpc: Move #ifdef'ed body of do_IRQ() into a separate function Michael Ellerman
2009-04-23  1:31 ` [PATCH 2/6] powerpc: Move stack overflow check " Michael Ellerman
2009-04-23  1:31 ` Michael Ellerman [this message]
2009-04-23  1:31 ` [PATCH 4/6] powerpc: Remove fallback to __do_IRQ() Michael Ellerman
2009-04-23  1:31 ` [PATCH 5/6] powerpc/powermac: Use generic_handle_irq() in gatwick_action() Michael Ellerman
2009-04-23  1:31 ` [PATCH 6/6] powerpc: We don't need __do_IRQ() anymore Michael Ellerman
2009-04-23 16:49 ` [PATCH 1/6] powerpc: Move #ifdef'ed body of do_IRQ() into a separate function Scott Wood
2009-04-24  3:39   ` Michael Ellerman
2009-04-25 18:18 ` Christoph Hellwig
2009-04-28  0:49   ` Michael Ellerman
2009-04-29 11:44     ` Christoph Hellwig
2009-04-29 12:48       ` Kumar Gala
2009-04-29 19:58         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172bff338316019112e982bafe61e862d1847a2.1240450296.git.michael@ellerman.id.au \
    --to=michael@ellerman.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.