From: "Rustad, Mark D" <mark.d.rustad@intel.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Cc: "David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>
Subject: Re: [PATCH net-next] tools: bpf: handle long path in jit disasm
Date: Thu, 2 Nov 2017 21:19:44 +0000 [thread overview]
Message-ID: <1174FFEE-A6FF-4FC5-A6CF-249D99124441@intel.com> (raw)
In-Reply-To: <20171102080945.7436-1-bhole_prashant_q7@lab.ntt.co.jp>
[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]
> On Nov 2, 2017, at 1:09 AM, Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp> wrote:
>
> Use PATH_MAX instead of hardcoded array size 256
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> ---
> tools/bpf/bpf_jit_disasm.c | 3 ++-
> tools/bpf/bpftool/jit_disasm.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpf_jit_disasm.c b/tools/bpf/bpf_jit_disasm.c
> index 422d9abd666a..75bf526a0168 100644
> --- a/tools/bpf/bpf_jit_disasm.c
> +++ b/tools/bpf/bpf_jit_disasm.c
> @@ -27,6 +27,7 @@
> #include <sys/klog.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <limits.h>
>
> #define CMD_ACTION_SIZE_BUFFER 10
> #define CMD_ACTION_READ_ALL 3
> @@ -51,7 +52,7 @@ static void get_exec_path(char *tpath, size_t size)
> static void get_asm_insns(uint8_t *image, size_t len, int opcodes)
> {
> int count, i, pc = 0;
> - char tpath[256];
> + char tpath[PATH_MAX];
Seems like such a nice thing, *but* PATH_MAX is 4096. Can things really tolerate 4k on the stack here?
> struct disassemble_info info;
> disassembler_ftype disassemble;
> bfd *bfdf;
> diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
> index 5937e134e408..1551d3918d4c 100644
> --- a/tools/bpf/bpftool/jit_disasm.c
> +++ b/tools/bpf/bpftool/jit_disasm.c
> @@ -21,6 +21,7 @@
> #include <dis-asm.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <limits.h>
>
> #include "json_writer.h"
> #include "main.h"
> @@ -80,7 +81,7 @@ void disasm_print_insn(unsigned char *image, ssize_t len, int opcodes)
> disassembler_ftype disassemble;
> struct disassemble_info info;
> int count, i, pc = 0;
> - char tpath[256];
> + char tpath[PATH_MAX];
Same comment here.
> bfd *bfdf;
>
> if (!len)
next prev parent reply other threads:[~2017-11-02 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 8:09 [PATCH net-next] tools: bpf: handle long path in jit disasm Prashant Bhole
2017-11-02 11:25 ` David Miller
2017-11-02 21:19 ` Rustad, Mark D [this message]
2017-11-03 0:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174FFEE-A6FF-4FC5-A6CF-249D99124441@intel.com \
--to=mark.d.rustad@intel.com \
--cc=ast@kernel.org \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.