All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, Takashi Iwai <tiwai@suse.de>,
	dwysocha@redhat.com, linux-kernel@vger.kernel.org,
	"Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org,
	linux-afs@lists.infradead.org
Subject: Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
Date: Wed, 20 Jan 2021 16:12:09 +0000	[thread overview]
Message-ID: <1175866.1611159129@warthog.procyon.org.uk> (raw)
In-Reply-To: <20201020075307.GA17780@infradead.org>

Christoph Hellwig <hch@infradead.org> wrote:

> what prevents us from killing of the last ->readpages instance?
> Leaving half-finished API conversions in the tree usually doesn't end
> well..

I never got around to making cachefiles actually use ->readpages, so that's
not an issue.

David


  parent reply	other threads:[~2021-01-20 16:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 14:56 [PATCH] cachefiles: Drop superfluous readpages aops NULL check David Howells
2020-10-19 15:05 ` Matthew Wilcox
2020-10-20  7:53 ` Christoph Hellwig
2020-10-20 11:06   ` Matthew Wilcox
2021-01-20 16:12 ` David Howells [this message]
2021-01-20 16:11 David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175866.1611159129@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=dwysocha@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.