All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yu, Ke" <ke.yu@intel.com>
To: Christian Limpach <christian.limpach@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: cdrom config change break HVM reboot
Date: Wed, 23 Aug 2006 23:08:42 +0800	[thread overview]
Message-ID: <117E3EB5059E4E48ADFF2822933287A4F92C6C@pdsmsx404.ccr.corp.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

Hi Christian, 

In cset 10921 "Use xenstore to configure ioemu block devices", a empty cdrom entry is added in /etc/xen/xmexample.hvm:

disk = [ 'file:/var/images/min-el3-i386.img,hda,w', ',hdc:cdrom,r' ]

this actually breaks the HVM reboot in ia32e, since the UNAME of cdrom entry is None and control panel reboot logic can not handle this.

When I try the following config, the reboot works. 

disk = [ 'file:/var/images/min-el3-i386.img,hda,w', 'file:/var/image/cdrom.iso,hdc:cdrom,r' ]

Per my understanding, when user want to use cdrom, they should specify a physical ISO file or device,  a empty cdrom entry is not valid. So I suggest the follwing simple patch, how do you think?

diff -r b688d4a68a3e tools/examples/xmexample.hvm
--- a/tools/examples/xmexample.hvm      Tue Aug 22 14:59:16 2006 +0100
+++ b/tools/examples/xmexample.hvm      Wed Aug 23 22:48:46 2006 +0800
@@ -70,7 +70,8 @@ vif = [ 'type=ioemu, bridge=xenbr0' ]
 # and MODE is r for read-only, w for read-write.

 #disk = [ 'phy:hda1,hda1,r' ]
-disk = [ 'file:/var/images/min-el3-i386.img,hda,w', ',hdc:cdrom,r' ]
+#disk = [ 'file:/var/images/min-el3-i386.img,hda,w', 'file:/var/images/cdrom.iso,hdc:cdrom,r' ]
+disk = [ 'file:/var/images/min-el3-i386.img,hda,w' ]

 #----------------------------------------------------------------------------
 # Configure the behaviour when a domain exits.  There are three 'reasons'


Best Regards
Ke

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2006-08-23 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-23 15:08 Yu, Ke [this message]
2006-08-23 20:17 ` cdrom config change break HVM reboot Ewan Mellor
2006-08-24  6:00 Yu, Ke
2006-08-30  1:57 ` Ewan Mellor
2006-08-30 11:32 Yu, Ke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=117E3EB5059E4E48ADFF2822933287A4F92C6C@pdsmsx404.ccr.corp.intel.com \
    --to=ke.yu@intel.com \
    --cc=christian.limpach@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.