Re: [PATCH] ext4: Allocate entire range in zero range

From: Lukas Czerner <lczerner@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Allocate entire range in zero range
Date: Thu, 19 Feb 2015 06:31:00 -0500 (EST)	[thread overview]
Message-ID: <1187673811.14968384.1424345460001.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20150219004935.GR4251@dastard>

Hi Dave,

yes I am planning to send a regression test for this case as well.

Thanks!
-Lukas

----- Original Message -----
From: "Dave Chinner" <david@fromorbit.com>
To: "Lukas Czerner" <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Sent: Thursday, February 19, 2015 1:49:35 AM
Subject: Re: [PATCH] ext4: Allocate entire range in zero range

On Wed, Feb 18, 2015 at 05:49:28PM +0100, Lukas Czerner wrote:
> Currently there is a bug in zero range code which causes zero range
> calls to only allocate block aligned portion of the range, while
> ignoring the rest in some cases.
> 
> In some cases, namely if the end of the range is past isize, we do
> attempt to preallocate the last nonaligned block. However this might
> cause kernel to BUG() in some carefully designed zero range requests on
> setups where page size > block size.

Is there a regression test you could write to exercise these casesi
in future?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html