From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] fm10k: fix wrong VLAN value in RX mbuf
Date: Tue, 24 Nov 2015 11:28:22 +0100
Message-ID: <11881693.ZHnXqqknjk@xps13>
References: <1448000935-29391-1-git-send-email-shaopeng.he@intel.com>
 <1448028587-7718-1-git-send-email-shaopeng.he@intel.com>
 <20151120083527.64ffd576@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Shaopeng He <shaopeng.he@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 7FF718E83
 for <dev@dpdk.org>; Tue, 24 Nov 2015 11:29:40 +0100 (CET)
Received: by wmww144 with SMTP id w144so19804693wmw.0
 for <dev@dpdk.org>; Tue, 24 Nov 2015 02:29:40 -0800 (PST)
In-Reply-To: <20151120083527.64ffd576@xeon-e3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > vlan_tci should be copied from RX descriptor to mbuf,
> > and flag PKT_RX_VLAN_PKT should be set for every RX packet,
> > this patch fixes this issue.
> > Packets in fm10k device always carry at least one VLAN tag.
> > For those packets coming in without VLAN tag,
> > the port default VLAN tag will be used.
> > So in fm10k, always PKT_RX_VLAN_PKT flag is set and vlan_tci
> > is valid for each RX packet's mbuf.
> > 
> > Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
> 
> Looks good thanks.
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks