From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB5AC433FE for ; Thu, 10 Dec 2020 17:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97BE923D57 for ; Thu, 10 Dec 2020 17:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392544AbgLJR4P (ORCPT ); Thu, 10 Dec 2020 12:56:15 -0500 Received: from mga17.intel.com ([192.55.52.151]:38323 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392468AbgLJRxA (ORCPT ); Thu, 10 Dec 2020 12:53:00 -0500 IronPort-SDR: 1Aq82sxJUnJJuzN4daFGRIY+GQpuuODCQCaPcy7OD6dufrCXGvuER3diRoSMUqScA2jZBKqmtR LYOSRYl5Px2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="154110160" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="154110160" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:51:15 -0800 IronPort-SDR: O9xj5AStRn1R/+n9qHsHejcuXQqjPe2N7zBcihmXhLps93EdZZo2Vwdx+lzK7LvWiIO3KGBQ+L xuouzydGXi3A== X-IronPort-AV: E=Sophos;i="5.78,409,1599548400"; d="scan'208";a="320190821" Received: from nabuhijl-mobl.ger.corp.intel.com (HELO [10.251.185.230]) ([10.251.185.230]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:51:10 -0800 Subject: Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count To: Thomas Gleixner , Joonas Lahtinen , Jerry Snitselaar , linux-kernel@vger.kernel.org, Tvrtko Ursulin , Chris Wilson Cc: Jason Gunthorpe , Peter Zijlstra , intel-gfx@lists.freedesktop.org, Matthew Garrett , James Bottomley , David Airlie , Jarkko Sakkinen , dri-devel@lists.freedesktop.org, linux-integrity@vger.kernel.org, Peter Huewe References: <20201205014340.148235-1-jsnitsel@redhat.com> <20201205014340.148235-3-jsnitsel@redhat.com> <875z5e99ez.fsf@nanos.tec.linutronix.de> <160758677957.5062.15497765500689083558@jlahtine-mobl.ger.corp.intel.com> <87v9d9k49q.fsf@nanos.tec.linutronix.de> <87pn3hk12r.fsf@nanos.tec.linutronix.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <118a2e24-12f8-8a5c-193e-67e5ac37cac1@linux.intel.com> Date: Thu, 10 Dec 2020 17:51:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn3hk12r.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2020 17:44, Thomas Gleixner wrote: > On Thu, Dec 10 2020 at 17:09, Tvrtko Ursulin wrote: >> On 10/12/2020 16:35, Thomas Gleixner wrote: >>> I'll send out a series addressing irq_to_desc() (ab)use all over the >>> place shortly. i915 is in there... >> >> Yep we don't need atomic, my bad. And we would care about the shared >> interrupt line. And without atomic the extra accounting falls way below >> noise. > > You have to be careful though. If you make the accumulated counter 64 > bit wide then you need to be careful vs. 32bit machines. Yep, thanks, I am bad jumping from one thing to another. Forgot about the read side atomicity completely.. >> So in the light of it all, it sounds best I just quickly replace our >> abuse with private counting and then you don't have to deal with it in >> your series. > > I mostly have it. Still chewing on the 32bit vs. 64bit thing. And > keeping it in my series allows me to remove the export of irq_to_desc() > at the end without waiting for your tree to be merged. > > Give me a few. Ok. Regards, Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDBC5C4361B for ; Thu, 10 Dec 2020 17:51:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9249D23DE3 for ; Thu, 10 Dec 2020 17:51:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9249D23DE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A60826E435; Thu, 10 Dec 2020 17:51:18 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D95B6E435; Thu, 10 Dec 2020 17:51:17 +0000 (UTC) IronPort-SDR: /jlUou1kIhg+luXYOyYTOniu+4yKbVpj5ND+8OSh/+pFD9ETszrDbj9g2xg3H5T1euMrbO75rp nJslFUHmrGpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="235894941" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="235894941" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:51:15 -0800 IronPort-SDR: O9xj5AStRn1R/+n9qHsHejcuXQqjPe2N7zBcihmXhLps93EdZZo2Vwdx+lzK7LvWiIO3KGBQ+L xuouzydGXi3A== X-IronPort-AV: E=Sophos;i="5.78,409,1599548400"; d="scan'208";a="320190821" Received: from nabuhijl-mobl.ger.corp.intel.com (HELO [10.251.185.230]) ([10.251.185.230]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:51:10 -0800 Subject: Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count To: Thomas Gleixner , Joonas Lahtinen , Jerry Snitselaar , linux-kernel@vger.kernel.org, Tvrtko Ursulin , Chris Wilson References: <20201205014340.148235-1-jsnitsel@redhat.com> <20201205014340.148235-3-jsnitsel@redhat.com> <875z5e99ez.fsf@nanos.tec.linutronix.de> <160758677957.5062.15497765500689083558@jlahtine-mobl.ger.corp.intel.com> <87v9d9k49q.fsf@nanos.tec.linutronix.de> <87pn3hk12r.fsf@nanos.tec.linutronix.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <118a2e24-12f8-8a5c-193e-67e5ac37cac1@linux.intel.com> Date: Thu, 10 Dec 2020 17:51:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn3hk12r.fsf@nanos.tec.linutronix.de> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Peter Zijlstra , intel-gfx@lists.freedesktop.org, Matthew Garrett , James Bottomley , Jason Gunthorpe , Jarkko Sakkinen , dri-devel@lists.freedesktop.org, linux-integrity@vger.kernel.org, Peter Huewe Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/12/2020 17:44, Thomas Gleixner wrote: > On Thu, Dec 10 2020 at 17:09, Tvrtko Ursulin wrote: >> On 10/12/2020 16:35, Thomas Gleixner wrote: >>> I'll send out a series addressing irq_to_desc() (ab)use all over the >>> place shortly. i915 is in there... >> >> Yep we don't need atomic, my bad. And we would care about the shared >> interrupt line. And without atomic the extra accounting falls way below >> noise. > > You have to be careful though. If you make the accumulated counter 64 > bit wide then you need to be careful vs. 32bit machines. Yep, thanks, I am bad jumping from one thing to another. Forgot about the read side atomicity completely.. >> So in the light of it all, it sounds best I just quickly replace our >> abuse with private counting and then you don't have to deal with it in >> your series. > > I mostly have it. Still chewing on the 32bit vs. 64bit thing. And > keeping it in my series allows me to remove the export of irq_to_desc() > at the end without waiting for your tree to be merged. > > Give me a few. Ok. Regards, Tvrtko _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8372C0018C for ; Thu, 10 Dec 2020 17:51:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2E8E23D57 for ; Thu, 10 Dec 2020 17:51:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2E8E23D57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 469756EAB1; Thu, 10 Dec 2020 17:51:19 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D95B6E435; Thu, 10 Dec 2020 17:51:17 +0000 (UTC) IronPort-SDR: /jlUou1kIhg+luXYOyYTOniu+4yKbVpj5ND+8OSh/+pFD9ETszrDbj9g2xg3H5T1euMrbO75rp nJslFUHmrGpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="235894941" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="235894941" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:51:15 -0800 IronPort-SDR: O9xj5AStRn1R/+n9qHsHejcuXQqjPe2N7zBcihmXhLps93EdZZo2Vwdx+lzK7LvWiIO3KGBQ+L xuouzydGXi3A== X-IronPort-AV: E=Sophos;i="5.78,409,1599548400"; d="scan'208";a="320190821" Received: from nabuhijl-mobl.ger.corp.intel.com (HELO [10.251.185.230]) ([10.251.185.230]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 09:51:10 -0800 To: Thomas Gleixner , Joonas Lahtinen , Jerry Snitselaar , linux-kernel@vger.kernel.org, Tvrtko Ursulin , Chris Wilson References: <20201205014340.148235-1-jsnitsel@redhat.com> <20201205014340.148235-3-jsnitsel@redhat.com> <875z5e99ez.fsf@nanos.tec.linutronix.de> <160758677957.5062.15497765500689083558@jlahtine-mobl.ger.corp.intel.com> <87v9d9k49q.fsf@nanos.tec.linutronix.de> <87pn3hk12r.fsf@nanos.tec.linutronix.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <118a2e24-12f8-8a5c-193e-67e5ac37cac1@linux.intel.com> Date: Thu, 10 Dec 2020 17:51:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn3hk12r.fsf@nanos.tec.linutronix.de> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Peter Zijlstra , intel-gfx@lists.freedesktop.org, Matthew Garrett , James Bottomley , Jason Gunthorpe , Jarkko Sakkinen , dri-devel@lists.freedesktop.org, linux-integrity@vger.kernel.org, Peter Huewe Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 10/12/2020 17:44, Thomas Gleixner wrote: > On Thu, Dec 10 2020 at 17:09, Tvrtko Ursulin wrote: >> On 10/12/2020 16:35, Thomas Gleixner wrote: >>> I'll send out a series addressing irq_to_desc() (ab)use all over the >>> place shortly. i915 is in there... >> >> Yep we don't need atomic, my bad. And we would care about the shared >> interrupt line. And without atomic the extra accounting falls way below >> noise. > > You have to be careful though. If you make the accumulated counter 64 > bit wide then you need to be careful vs. 32bit machines. Yep, thanks, I am bad jumping from one thing to another. Forgot about the read side atomicity completely.. >> So in the light of it all, it sounds best I just quickly replace our >> abuse with private counting and then you don't have to deal with it in >> your series. > > I mostly have it. Still chewing on the 32bit vs. 64bit thing. And > keeping it in my series allows me to remove the export of irq_to_desc() > at the end without waiting for your tree to be merged. > > Give me a few. Ok. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx