All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: leon@kernel.org, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()
Date: Tue, 08 Jun 2021 18:33:51 -0700	[thread overview]
Message-ID: <1190c96c38df650d7fdf3aa6d12674359ad16e51.camel@kernel.org> (raw)
In-Reply-To: <1622801307-34745-1-git-send-email-yang.lee@linux.alibaba.com>

On Fri, 2021-06-04 at 18:08 +0800, Yang Li wrote:
> When the code execute 'if (!priv->fs.arfs->wq)', the value of err is
> 0.
> So, we use -ENOMEM to indicate that the function
> create_singlethread_workqueue() return NULL.
> 
> Clean up smatch warning:
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
> mlx5e_arfs_create_tables() warn: missing error code 'err'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev
> when needed")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> 
> Changes in v2:
> --According to Saeed's suggestion, we modify the format of Fixes tag,
> --and initialize err to -ENOMEM.
> https://lore.kernel.org/patchwork/patch/1440018/
> 

applied to net-mlx5.

thanks !


      reply	other threads:[~2021-06-09  1:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 10:08 [PATCH v2] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables() Yang Li
2021-06-09  1:33 ` Saeed Mahameed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190c96c38df650d7fdf3aa6d12674359ad16e51.camel@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.