From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ImcXI-0003Pv-Mt
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:52:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ImcXH-0003Ll-3H
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:52:40 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ImcXG-0003LB-QP
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:52:38 -0400
Received: from honiara.magic.fr ([195.154.193.36])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <l_indien@magic.fr>) id 1ImcXE-0002bi-RQ
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:52:37 -0400
Subject: Re: [Qemu-devel] qemu/target-ppc op_helper.c
From: "J. Mayer" <l_indien@magic.fr>
In-Reply-To: <20071029213302.GB31674@hall.aurel32.net>
References: <20071029211200.GA31674@hall.aurel32.net>
	<1193692886.16781.360.camel@rapid>
	<20071029213302.GB31674@hall.aurel32.net>
Content-Type: text/plain
Date: Mon, 29 Oct 2007 22:52:29 +0100
Message-Id: <1193694749.16781.370.camel@rapid>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org


On Mon, 2007-10-29 at 22:33 +0100, Aurelien Jarno wrote:
> On Mon, Oct 29, 2007 at 10:21:26PM +0100, J. Mayer wrote:
> > 
> > On Mon, 2007-10-29 at 22:12 +0100, Aurelien Jarno wrote:
> > > > CVSROOT:        /sources/qemu
> > > > Module name:    qemu
> > > > Changes by:     Jocelyn Mayer <j_mayer> 07/10/27 17:59:46
> > > > 
> > > > Modified files:
> > > >        target-ppc     : op_helper.c 
> > > > 
> > > > Log message:
> > > >         PowerPC float bugfix: 64 bits float mantissa is 52 bits long.
> > > > 
> > > > CVSWeb URLs:
> > > > http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.55&r2=1.56
> > > 
> > > 
> > > I know that it looks strange, but this commit breaks perl. The function 
> > > mkdir(dir, mode) sometimes does not set the mode correctly. This can be
> > > easily reproduce on Debian by using "dpkg-source -x file.dsc", which
> > > fails due to wrong permission.
> > > 
> > > I am using qemu-system-ppc -M prep -cpu G3
> > 
> > Thanks for the report !
> > Could you please try replacing the 0x3FF mask with 0x7FF ? As the
> > exponent is supposed to be 11 bits, my patch is obviously still buggy...
> > I noticed there was a bug somewhere, but was not convinced it was in the
> > FPU emulation... Now ...
> > 
> 
> Yep that fixes the problem. Thanks a lot!

Great ! Thanks for your help !
I'll commit it in a minute !

> 
-- 
J. Mayer <l_indien@magic.fr>
Never organized