From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] eal: redefine logtype values
Date: Wed, 12 Apr 2017 17:15:56 +0200
Message-ID: <11937147.4rRz3cW7Er@xps13>
References: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, olivier.matz@6wind.com
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com
 [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 3671A2E8A
 for <dev@dpdk.org>; Wed, 12 Apr 2017 17:15:58 +0200 (CEST)
Received: by mail-wr0-f174.google.com with SMTP id l28so19636949wre.0
 for <dev@dpdk.org>; Wed, 12 Apr 2017 08:15:58 -0700 (PDT)
In-Reply-To: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-12 15:14, Pablo de Lara:
> After the changes in commit c1b5fa94a46f
> ("eal: support dynamic log types"), logtype is not treated as a
> bitmask, but a decimal value. Therefore, values have to be
> converted.
> 
> Fixes: c1b5fa94a46f ("eal: support dynamic log types")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
[...]
>  /* SDK log type, keep sync'd with rte_log_init() */
[...]
> +#define RTE_LOGTYPE_EAL        0 /**< Log related to eal. */
> +#define RTE_LOGTYPE_MALLOC     1 /**< Log related to malloc. */
> +#define RTE_LOGTYPE_RING       2 /**< Log related to ring. */
> +#define RTE_LOGTYPE_MEMPOOL    3 /**< Log related to mempool. */
> +#define RTE_LOGTYPE_TIMER      4 /**< Log related to timers. */
> +#define RTE_LOGTYPE_PMD        5 /**< Log related to poll mode driver. */
> +#define RTE_LOGTYPE_HASH       6 /**< Log related to hash table. */
> +#define RTE_LOGTYPE_LPM        7 /**< Log related to LPM. */
> +#define RTE_LOGTYPE_KNI        8 /**< Log related to KNI. */
> +#define RTE_LOGTYPE_ACL        9 /**< Log related to ACL. */
> +#define RTE_LOGTYPE_POWER     10 /**< Log related to power. */
> +#define RTE_LOGTYPE_METER     11 /**< Log related to QoS meter. */
> +#define RTE_LOGTYPE_SCHED     12 /**< Log related to QoS port scheduler. */
> +#define RTE_LOGTYPE_PORT      13 /**< Log related to port. */
> +#define RTE_LOGTYPE_TABLE     14 /**< Log related to table. */
> +#define RTE_LOGTYPE_PIPELINE  15 /**< Log related to pipeline. */
> +#define RTE_LOGTYPE_MBUF      16 /**< Log related to mbuf. */
> +#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
> +#define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
> +#define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */

I think you should use these values in rte_log_init,
instead of the hardcoded ones.
So the messages about keeping them sync'd could be removed :)