From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbdKAPYV convert rfc822-to-8bit (ORCPT ); Wed, 1 Nov 2017 11:24:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59134 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbdKAPYU (ORCPT ); Wed, 1 Nov 2017 11:24:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 629B281E1A Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1508923903.22379.77.camel@codethink.co.uk> References: <1508923903.22379.77.camel@codethink.co.uk> <20171016181206.GC121701@google.com> <20171003114219.900672076@linuxfoundation.org> <20171003114220.627158480@linuxfoundation.org> <1508168854.22379.25.camel@codethink.co.uk> <10708.1508426843@warthog.procyon.org.uk> <20171024231927.GA32603@google.com> To: Ben Hutchings Cc: dhowells@redhat.com, Eric Biggers , stable@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4.4 11/41] KEYS: fix writing past end of user-supplied buffer in keyring_read() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11968.1509549857.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 01 Nov 2017 15:24:17 +0000 Message-ID: <11969.1509549857@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 01 Nov 2017 15:24:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ben Hutchings wrote: > > So do we really make it keep filling the buffer, even though that contradicts > > the man page? > > I don't think any application is likely to care about this. The > documentation should also be changed to say that if the buffer is too > small, "data may or may not be copied to the buffer" or "the contents > of the buffer are undefined". Okay, let's go with that. David