From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH v7 0/3] new API to free consumed buffers in Tx ring Date: Wed, 15 Mar 2017 20:25:12 +0000 Message-ID: <11AACAFE-E97B-404A-80C4-C9279DEB9BB8@intel.com> References: <20170309205119.28170-1-bmcfall@redhat.com> <20170315180226.5999-1-bmcfall@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Thomas Monjalon , "Lu, Wenzhuo" , "olivier.matz@6wind.com" , "dev@dpdk.org" To: Billy McFall Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 99EC42C1A for ; Wed, 15 Mar 2017 21:25:14 +0100 (CET) In-Reply-To: <20170315180226.5999-1-bmcfall@redhat.com> Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Mar 16, 2017, at 2:02 AM, Billy McFall wrote: >=20 > See request from 11/21/2016: > http://dpdk.org/ml/archives/dev/2016-November/050585.html >=20 > Add a new API to free consumed buffers on TX ring. This addresses two > scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid a packet > copy. Increment the reference count of the packet and poll new API until > reference count is decremented. > 2) Application runs out of mbufs, or resets and is preparing for > additional run, call API to free consumed packets so processing can > continue. >=20 > API will return the number of packets freed (0-n) or error code if > feature not supported (-ENOTSUP) or input invalid (-ENODEV). >=20 > API for e1000 igb driver and vHost driver have been implemented. Other > drivers can be implemented over time. Some drivers implement a Tx done > flush routine that should be reused where possible. e1000 igb driver > and vHost driver do not have such functions. >=20 > --- > v2: > * Removed rte_eth_tx_buffer_flush() call and associated parameters > from new rte_eth_tx_done_cleanup() API. >=20 > * Remaining open issue is whether this should be a new API or overload=20 > existing rte_eth_tx_buffer() API with input parameter nb_pkts set to > 0. My concern is that overloading existing API will not provided > enough feedback to application. Application needs to know if feature > is supported and driver is attempting to free mbufs or not. >=20 > * If new API is supported, second open issue is if parameter free_cnt > should be included. It was in the original feature request. >=20 > --- > v3: > * Removed extra white space in rte_ethdev.h. > * Removed inline of new API function in rte_ethdev.h. >=20 > --- > v4: > * Added new API to documentation of per nic supported features. >=20 > --- > v5: > * Added documentation to the Programmer's Guide. >=20 > --- > v6: > * Rebase to master. > * Added Release Note. > * Addressed comments on documentation to the Programmer's Guide. > * Renamed feature string to "Free Tx mbuf on demand" and modified > feature string processing code to extend the maximum string length > from 20 characters to 25 characters. > * Reworded the commit log for PATCH 2/3 to attempt to clearify that the > API is independent of tx_rs_thresh. =20 > * Will address the rte_errno comment in a separate merge. >=20 > --- > v7: > * New API was located between rte_eth_tx_buffer and > rte_eth_tx_buffer_set_err_callback in the file. Moved this function > below the tx_buffer functions. > * Added previously acked-by tags to merge comments. > * Moved documentation content from the mempool documentation to the > ethdev documentation. >=20 >=20 > Billy McFall (3): > ethdev: new API to free consumed buffers in Tx ring > net/e1000: e1000 igb support to free consumed buffers > net/vhost: vHost support to free consumed buffers >=20 > doc/guides/conf.py | 7 +- > doc/guides/nics/features/default.ini | 4 +- > doc/guides/nics/features/e1000.ini | 1 + > doc/guides/nics/features/vhost.ini | 1 + > doc/guides/prog_guide/poll_mode_drv.rst | 28 +++++++ > doc/guides/rel_notes/release_17_05.rst | 7 +- > drivers/net/e1000/e1000_ethdev.h | 2 + > drivers/net/e1000/igb_ethdev.c | 1 + > drivers/net/e1000/igb_rxtx.c | 126 +++++++++++++++++++++++++++= +++++ > drivers/net/vhost/rte_eth_vhost.c | 11 +++ > lib/librte_ether/rte_ethdev.c | 14 ++++ > lib/librte_ether/rte_ethdev.h | 31 ++++++++ > 12 files changed, 229 insertions(+), 4 deletions(-) >=20 > --=20 > 2.9.3 >=20 Acked-by: Keith.Wiles@intel.com for the series. Regards, Keith