All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Lahav Schlesinger <lschlesinger@drivenets.com>
Cc: netdev@vger.kernel.org, dsahern@kernel.org
Subject: Re: [PATCH] ip: Support filter links/neighs with no master
Date: Tue, 24 Aug 2021 09:16:35 -0700	[thread overview]
Message-ID: <11a0051c-2d14-a479-c657-d49a2fce9a9d@gmail.com> (raw)
In-Reply-To: <20210824141625.dtwnvpejidy64kye@kgollan-pc>

On 8/24/21 8:16 AM, Lahav Schlesinger wrote:
>>> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
>>> index 85534aaf..a5b683f5 100644
>>> --- a/ip/ipaddress.c
>>> +++ b/ip/ipaddress.c
>>> @@ -61,7 +61,7 @@ static void usage(void)
>>>               "                            [ to PREFIX ] [ FLAG-LIST ] [ label LABEL ] [up]\n"
>>>               "       ip address [ show [ dev IFNAME ] [ scope SCOPE-ID ] [ master DEVICE ]\n"
>>
>> move [ nomaster ] to here on a new line to keep the existing line
>> length, and
>>
>>>               "                         [ type TYPE ] [ to PREFIX ] [ FLAG-LIST ]\n"
>>> -             "                         [ label LABEL ] [up] [ vrf NAME ] ]\n"
>>> +             "                         [ label LABEL ] [up] [ vrf NAME ] [ nomaster ] ]\n"
>>
>> make this 'novrf' for consistency with existing syntax.
>>
>> Similarly for the other 2 commands.
> 
> I think "nomaster" is more fitting here, because this option only affects
> interfaces that have no master at all, so e.g. slaves of a bundle will
> not be returned by the "nomaster" option, even if they are in the default VRF.

I was thinking both - 'nomaster' for bridges and 'novrf' for VRFs. Just
friendlier syntax for the latter.

> 
> I'm planning next to add support for the "novrf" option which will indeed
> only affect interfaces which are in the default VRF, even if they have a
> master.

ok,


      reply	other threads:[~2021-08-24 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 10:45 [PATCH] ip: Support filter links/neighs with no master Lahav Schlesinger
2021-08-24  4:19 ` David Ahern
2021-08-24 14:16   ` Lahav Schlesinger
2021-08-24 16:16     ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11a0051c-2d14-a479-c657-d49a2fce9a9d@gmail.com \
    --to=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=lschlesinger@drivenets.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.