All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <jroedel@suse.de>
Cc: linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com,
	tglx@linutronix.de, x86@kernel.org
Subject: Re: Failure to shutdown/reboot with intel_iommu=on
Date: Mon, 11 May 2020 21:59:31 +0200	[thread overview]
Message-ID: <11a3945a-f743-ac32-135c-1de026da66c9@kleine-koenig.org> (raw)
In-Reply-To: <bd9fb298-1ad3-fd4c-19f7-aae4c2b62daa@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 833 bytes --]

On 5/9/20 3:58 AM, Lu Baolu wrote:
> Hi Uwe,
> 
> Have you tried commenting out intel_disable_iommus() in
> intel_iommu_shutdowan()?
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0182cff2c7ac..532e62600f95 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4928,8 +4928,10 @@ void intel_iommu_shutdown(void)
>         for_each_iommu(iommu, drhd)
>                 iommu_disable_protect_mem_regions(iommu);
> 
> +#if 0
>         /* Make sure the IOMMUs are switched off */
>         intel_disable_iommus();
> +#endif
> 
>         up_write(&dmar_global_lock);
>  }

I just tested that and it didn't help. The machine still hangs with the
same symptoms as reported before.

Best regards
Uwe


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-05-11 19:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 14:46 Failure to shutdown/reboot with intel_iommu=on Uwe Kleine-König
2020-05-08 15:07 ` Joerg Roedel
2020-05-09  1:58   ` Lu Baolu
2020-05-11 19:59     ` Uwe Kleine-König [this message]
2020-05-11 20:16       ` Uwe Kleine-König
2020-05-11 13:43   ` Lenny Szubowicz
2020-05-11 19:58     ` Uwe Kleine-König
2020-05-12 13:34     ` Joerg Roedel
2020-05-12 20:00       ` Lenny Szubowicz
2020-05-12 21:13         ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11a3945a-f743-ac32-135c-1de026da66c9@kleine-koenig.org \
    --to=uwe@kleine-koenig.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.