From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1984CC433DB for ; Fri, 26 Feb 2021 15:59:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 648ED64F03 for ; Fri, 26 Feb 2021 15:59:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 648ED64F03 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFfWo-0003bB-0y for qemu-devel@archiver.kernel.org; Fri, 26 Feb 2021 10:59:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFfVt-00037R-8B for qemu-devel@nongnu.org; Fri, 26 Feb 2021 10:58:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lFfVp-0003BW-5B for qemu-devel@nongnu.org; Fri, 26 Feb 2021 10:58:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614355117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5PFHvltxej26fhfHzFILVAIOg0sHnOaMIvmalTHix+w=; b=hxwgqFnOh8xAyNHEOU+7IuW4QKpc5BLv4vZERMtvFLupnjE8i+Fv6wtXUm5jVcJNTcHbpD YhSsGVY+D1W3dg4JxXRBIgo5CWpB3cnHORCX0CLikH/4y0PsZYywvZVeQSSqF1qKKzBGWR /6O9Rmtzu6ExNFWUdgeYb9lLYeuc9fQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-vqpOD1MUN2CZlFoPyTdT9w-1; Fri, 26 Feb 2021 10:58:34 -0500 X-MC-Unique: vqpOD1MUN2CZlFoPyTdT9w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 896411E562; Fri, 26 Feb 2021 15:58:33 +0000 (UTC) Received: from [10.3.113.12] (ovpn-113-12.phx2.redhat.com [10.3.113.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E91960BE5; Fri, 26 Feb 2021 15:58:26 +0000 (UTC) To: Kevin Wolf , qemu-devel@nongnu.org References: <20210224135255.253837-1-kwolf@redhat.com> <20210224135255.253837-7-kwolf@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Subject: Re: [PATCH v2 06/31] qapi/qom: Add ObjectOptions for dbus-vmstate Message-ID: <11a6a75b-2e84-9033-d15c-f30b40c45c07@redhat.com> Date: Fri, 26 Feb 2021 09:58:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210224135255.253837-7-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.349, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, libvir-list@redhat.com, jasowang@redhat.com, armbru@redhat.com, mreitz@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/24/21 7:52 AM, Kevin Wolf wrote: > This adds a QAPI schema for the properties of the dbus-vmstate object. > > A list represented as a comma separated string is clearly not very > QAPI-like, but for now just describe the existing interface. Does your alias proposal give us a path forward for improving that down the road? Or maybe it's not an alias we need, but a new field with better QAPI-like semantics, deprecate the old one, and wait out the 2 release cycles? > > Signed-off-by: Kevin Wolf > --- > qapi/qom.json | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/qapi/qom.json b/qapi/qom.json > index 1dbc95fb53..a6a5049707 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -232,6 +232,22 @@ > 'base': 'CryptodevBackendProperties', > 'data': { 'chardev': 'str' } } > > +## > +# @DBusVMStateProperties: > +# > +# Properties for dbus-vmstate objects. > +# > +# @addr: the name of the DBus bus to connect to > +# > +# @id-list: a comma separated list of DBus IDs of helpers whose data should be > +# included in the VM state on migration > +# > +# Since: 5.0 > +## > +{ 'struct': 'DBusVMStateProperties', > + 'data': { 'addr': 'str' , > + '*id-list': 'str' } } Matches backends/dbus-vmstate.c:dbus_vmstate_class_init(), including splitting id-list into a GHashTable with get_id_list_set(). Since there is benefit to documenting/converting our existing API in this series without dragging it out by also trying to fix the warts, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org