All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
	"Kai Wasserbäch" <kai@dev.carbon-project.org>
Cc: Thorsten Leemhuis <linux@leemhuis.info>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Fw: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link:
Date: Mon, 05 Dec 2022 17:02:33 -0800	[thread overview]
Message-ID: <11a9fe60f5333a931b8d75f67808b6d923c16dfa.camel@perches.com> (raw)
In-Reply-To: <20221205131424.36909375d90d5a40cd028bc0@linux-foundation.org>

On Mon, 2022-12-05 at 13:14 -0800, Andrew Morton wrote:
> Apparently MAINTAINERS is hard to read.  Please review?
> 
> Thanks.
> 
> Begin forwarded message:
> 
> Date: Sun,  4 Dec 2022 12:33:37 +0100
> From: Kai Wasserbäch <kai@dev.carbon-project.org>
> To: linux-kernel@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>, Thorsten Leemhuis <linux@leemhuis.info>
> Subject: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link:
> 
> 
> Hey,
> Thorsten Leemhuis suggested the following two changes to checkpatch, which
> I hereby humbly submit for review. Please let me know if any changes
> would be required for acceptance.
> 
> NOTES:
> - checkpatch is rather long, so I might have chosen the wrong section to
>   add these two checks. Any better placement suggestion is welcome.
> - checkpatch implements custum versions of Perl core modules, that might
>   be an future area for clean-ups? Eg. right off the bat there is a
>   `uniq` implementation. List::Util (core module since 5.8.0 (5.7.3 to
>   be pedantic)) has a far better performing version in XS.

Maybe.  I don't know there are that many generic functions
that could be used.  You are welcome find some.

> 
> Cheers,
> Kai
> 
> Suggested-by: Thorsten Leemhuis <linux@leemhuis.info>
> Signed-off-by: Kai Wasserbäch <kai@dev.carbon-project.org>
> 
> 
> Kai Wasserbäch (2):
>   feat: checkpatch: error on usage of a Buglink tag in the commit log

Why, what's wrong with a buglink reference?

>   feat: checkpatch: Warn about Reported-by: not being followed by a
>     Link:

I think this is unnecessary.


       reply	other threads:[~2022-12-06  1:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221205131424.36909375d90d5a40cd028bc0@linux-foundation.org>
2022-12-06  1:02 ` Joe Perches [this message]
2022-12-06  1:19   ` Fw: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link: Joe Perches
2022-12-06  4:55   ` Thorsten Leemhuis
2022-12-06  5:54     ` Joe Perches
2022-12-06  6:27       ` Thorsten Leemhuis
2022-12-06  7:17         ` Thorsten Leemhuis
2022-12-06  7:44           ` Joe Perches
2022-12-06  8:50             ` Thorsten Leemhuis
2022-12-06  9:21               ` Joe Perches
2022-12-06 10:06                 ` Thorsten Leemhuis
2022-12-06 10:58                   ` Joe Perches
2022-12-08 13:18                 ` Thorsten Leemhuis
2022-12-08 17:22                   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11a9fe60f5333a931b8d75f67808b6d923c16dfa.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=kai@dev.carbon-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.