From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 23 Oct 2020 11:52:45 +0200 Subject: [PATCH V2 1/7] env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set In-Reply-To: <0b5d8e59-fabc-db9c-7807-145f0de2b0bc@gmail.com> References: <20200707185139.2225-1-marex@denx.de> <20200731214000.GP6965@bill-the-cat> <0b5d8e59-fabc-db9c-7807-145f0de2b0bc@gmail.com> Message-ID: <11bfe552-243b-4320-60da-b228cf8e8469@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/23/20 10:58 AM, Simon Goldschmidt wrote: > Am 31.07.2020 um 23:40 schrieb Tom Rini: >> On Tue, Jul 07, 2020 at 08:51:33PM +0200, Marek Vasut wrote: >> >>> If the ENV_ACCESS_IGNORE_FORCE is set, inform user that the variable >>> cannot be force-set if such attempt happens. >>> >>> Signed-off-by: Marek Vasut >>> Reviewed-by: Tom Rini >> >> Applied to u-boot/master, thanks! >> > > Sorry I haven't followed this and wasn't able to report this earlier, > but I think this is wrong: This warning is issued when 0 is returned, > which means the change is accepted, not rejected. I think there was a subsequent discussion on this topic in the ML, [PATCH] Revert "env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set", I think we reached a conclusion this patch was OK. But if you did more digging and found a problem, please send a patch / provide details.