Re: [PATCH 3/5] drm/amdgpu: fix comment on amdgpu_bo_va

From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
	<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 3/5] drm/amdgpu: fix comment on amdgpu_bo_va
Date: Tue, 29 Aug 2017 10:19:21 +0800	[thread overview]
Message-ID: <11c0c2cf-b785-a23d-5bb9-358693204c56@amd.com> (raw)
In-Reply-To: <1503946244-1535-3-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>

Reviewed-by: Chunming Zhou <david1.zhou@amd.com>


On 2017年08月29日 02:50, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> Except for the reference count all other members are protected
> by the VM PD being reserved.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> index e613ba4..42492e6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> @@ -49,9 +49,11 @@ struct amdgpu_bo_va {
>   	struct amdgpu_vm_bo_base	base;
>   
>   	/* protected by bo being reserved */
> -	struct dma_fence	        *last_pt_update;
>   	unsigned			ref_count;
>   
> +	/* all other members protected by the VM PD being reserved */
> +	struct dma_fence	        *last_pt_update;
> +
>   	/* mappings for this bo_va */
>   	struct list_head		invalids;
>   	struct list_head		valids;

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx